Closed Bug 1303836 Opened 8 years ago Closed 7 years ago

Web Replay debugger/frontend changes

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhackett1024, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Splitting this off from bug 1207696 per bug 1207696 comment 243. The attached patch has the changes to the debugger and browser frontend made in part 15a there. This patch changes the UI in the old debugger to add rewind and reverse-stepping buttons, but it would also be fine to remove changes to the old debugger from this patch and make similar changes to the new debugger (I don't know which parts need to change for the new debugger, though). All changes to the UI in this patch are gated on the devtools.recordreplay.enabled pref, which is off by default. The main thing I'd like is that these changes land (to the old or new debugger) by the time bug 1207696 lands, so that the record/replay system can be manually and automatically tested. It's fine if these changes land before bug 1207696, though; trying to create a record/replay tab without part 15b of that bug will cause the new tab to just be a normal tab.
Attachment #8792624 - Flags: review?(jlong)
Not sure what priority to assign here: is this actively being worked on? If so, it should probably be P1. Tentatively assigning P3 for now.
Priority: -- → P3
Comment on attachment 8792624 [details] [diff] [review] patch Now that the new debugger has landed in Nightly, you might want to split up your debugger changes and implement them at https://github.com/devtools-html/debugger.html As for the rest of the non-debugger changes, :ochameau or :jryans should be able to take a look. You'll very likely to get a faster review as well.
Flags: needinfo?(bhackett1024)
Attachment #8792624 - Flags: review?(jlong)
This is now in the new UI.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
Flags: needinfo?(bhackett1024)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: