The default bug view has changed. See this FAQ.

[FlyWeb] Fix shutdown leak of FlyWebService

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM: Flyweb
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: djvj, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
Created attachment 8792663 [details] [diff] [review]
fix-flywebservice-leak.patch

Noticed this when testing the test-suite code.  Using FlyWebService causes a shutdown leak because the FlyWebService singleton (stored as a global) is never destroyed.  It should be destroyed on shutdown.

Patch attached.
Attachment #8792663 - Flags: review?(mconley)
Comment on attachment 8792663 [details] [diff] [review]
fix-flywebservice-leak.patch

Review of attachment 8792663 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not too privy to the FlyWebService code at all, but clearing this global on shutdown makes sense, and it looks like we're obeying the rules of ClearOnShutdown.h. r=me.
Attachment #8792663 - Flags: review?(mconley) → review+

Comment 2

6 months ago
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8429f8baca
Fix shutdown leak of FlyWebService. r=mconley

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8d8429f8baca
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Updated

4 months ago
Product: Toolkit → Core
You need to log in before you can comment on or make changes to this bug.