Closed
Bug 1303865
Opened 8 years ago
Closed 8 years ago
[FlyWeb] Fix shutdown leak of FlyWebService
Categories
(Core Graveyard :: DOM: Flyweb, defect)
Core Graveyard
DOM: Flyweb
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: djvj, Unassigned)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
Noticed this when testing the test-suite code. Using FlyWebService causes a shutdown leak because the FlyWebService singleton (stored as a global) is never destroyed. It should be destroyed on shutdown. Patch attached.
Attachment #8792663 -
Flags: review?(mconley)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8792663 [details] [diff] [review] fix-flywebservice-leak.patch Review of attachment 8792663 [details] [diff] [review]: ----------------------------------------------------------------- I'm not too privy to the FlyWebService code at all, but clearing this global on shutdown makes sense, and it looks like we're obeying the rules of ClearOnShutdown.h. r=me.
Attachment #8792663 -
Flags: review?(mconley) → review+
Pushed by kvijayan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8429f8baca Fix shutdown leak of FlyWebService. r=mconley
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d8429f8baca
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
Assignee | |
Updated•8 years ago
|
Product: Toolkit → Core
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•