1303878 - Fix TODOs in WebGL

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1303878 - Fix todos in WebGL. -

Review commit: https://reviewboard.mozilla.org/r/79610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79610/

Comment 2

[Ethan Lin[:ethlin]]

Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

https://reviewboard.mozilla.org/r/79610/#review79310

Looks good to me. Some functions are modified in Bug 1303879. This should commit with Bug 1303879 together.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/658c0c2a4b48
Fix todos in WebGL. - r=mtseng

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/658c0c2a4b48

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/658c0c2a4b48

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]: bad webgl2
[Describe test coverage new/current, TreeHerder]: conformance suite
[Risks and why]: low. This is pretty well understood.
[String/UUID change made/needed]: none

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

WebGL2 is planned for Beta50, let's stabilize this on Aurora51 and if there are no problems I plan to include this in 50.0b4 on 10/03.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5e28a73451c9

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

WebGL2 is planned for Fx50, Beta+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Jeff landed this. Had to be backed out for bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=1706115&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-beta/rev/ca2593daaa91f717e3ae65f049308309a31969a2

Comment 11

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b1c16064e3ec621e0d07668918f7d7e48d8e347