Fix TODOs in WebGL

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Blocks: 1303879

Comment 2

2 years ago
mozreview-review
Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

https://reviewboard.mozilla.org/r/79610/#review79310

Looks good to me. Some functions are modified in Bug 1303879. This should commit with Bug 1303879 together.
Attachment #8792690 - Flags: review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/658c0c2a4b48
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Comment 6

2 years ago
Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]: bad webgl2
[Describe test coverage new/current, TreeHerder]: conformance suite
[Risks and why]: low. This is pretty well understood.
[String/UUID change made/needed]: none
Attachment #8792690 - Flags: review?(mtseng) → approval-mozilla-aurora?

Updated

2 years ago
status-firefox50: --- → affected
status-firefox51: --- → affected

Comment 7

2 years ago
Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

WebGL2 is planned for Beta50, let's stabilize this on Aurora51 and if there are no problems I plan to include this in 50.0b4 on 10/03.
Attachment #8792690 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

2 years ago
Blocks: 1306480

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e28a73451c9
status-firefox51: affected → fixed

Comment 9

2 years ago
Comment on attachment 8792690 [details]
Bug 1303878 - Fix todos in WebGL. -

WebGL2 is planned for Fx50, Beta+
Attachment #8792690 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.