Closed Bug 1304080 Opened 10 years ago Closed 6 years ago

Sites with untrusted issuers *and* SHA-1 certs issued in 2016 show SHA-1 error

Categories

(Firefox :: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1524323

People

(Reporter: April, Unassigned)

References

()

Details

(Keywords: sec-moderate)

I was visiting https://wiki.cacert.org/, which has two errors: 1) the cert is issued off of an unknown certificate authority 2) the cert uses a SHA-1 signature algorithm, and was issued in 2016 Firefox displays SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED, but it should probably be showing SEC_ERROR_UNKNOWN_ISSUER. Chrome, for reference, does display NET::ERR_CERT_AUTHORITY_INVALID. I would also note that when you go to Add Exception..., it *does* show that it's an unknown issuer.
Lowering to moderate since the exception screen does at least show the important error, although someone in a hurry might still approve it assuming it's the same as the "it's good enough for me" SHA1 error.
Keywords: sec-high → sec-moderate
> the exception screen does at least show the important error The "add exception" button lets the user assume he whitelists (a otherwise valid certificate) *for the sha1 error*. I agree, it's only moderate because the exception screen explains the real error, but that screen contains a lots of technical informations, so it's easy to miss it. And a MitM can replace the warning explaining that the certificate is not trusted by that sha1 warning. (and surprisingly https://sha1-2017.badssl.com/ doesn't display a warning? I had to check to compare...) The message displayed: > Your connection is not secure > > The owner of wiki.cacert.org has configured their website improperly. To protect your information from being stolen, Firefox Developer Edition has not connected to this website. > > Learn more… > > Report errors like this to help Mozilla identify and block malicious sites > > wiki.cacert.org uses an invalid security certificate. > > The certificate is not trusted because it was signed using a signature algorithm that was disabled because that algorithm is not secure. > > Error code: SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED
@tdelmas: Firefox errors for SHA-1 certs issued in 2016. sha1-2017.badssl.com expires in 2017, but it was issued in 2015.
Keeler, can you advise on the error ranking here?
Flags: needinfo?(dkeeler)
I'm not sure I have a strong opinion about this. In general we prioritize errors found in intermediates over end-entities. Other than that, we more or less return the first error we encounter. The problem here is that the (untrusted) root certificate is what has the weak signature (md5 for wiki.cacert.org in this case, but the same thing will happen for sha1 when we disable it entirely). We check the signature algorithm and other properties before going on to find a potential issuer when path building, so for this root we encounter the weak signature algorithm error before (hypothetically) discovering that it doesn't have a trusted issuer. We could change how we return errors, but if the concern is that users will see the error "SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED" and think "bah, that's just Firefox being paranoid about sha1", I don't think that's going to address the fundamental issue, which is that users really can't make an informed safety/privacy decision based on one error code - it's reductive and may not represent the complete picture. (Note that if the end-entity was the one with the weak signature algorithm, we would return SEC_ERROR_UNKNOWN_ISSUER.)
Flags: needinfo?(dkeeler)
At the very least, they should be consistent on what error is presented. Seeing one error in one place but a different error in another is very confusing. Is it possible for us to present more than one error code on the error page, if it encounters multiple errors like this? In this specific case, I think untrusted issuer > signature algorithm, especially since so many people are kind of burnt out on the SHA-1 thing and would happily click through it blindly.
Priority: -- → P3
Whiteboard: [psm-backlog]

-> frontend

Component: Security: PSM → Security
Priority: P3 → --
Product: Core → Firefox
Whiteboard: [psm-backlog]

Seems like another case of bug 1524323

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

Firefox before Quantum actually used to report multiple errors.

This is what you get with the current version [if you allow TLS1.0]
Websites prove their identity via certificates, which are valid for a set time period. The certificate for www.pizzolo.com expired on 3/31/2010.
Error code: SEC_ERROR_UNKNOWN_ISSUER

This is what you got before Quantum:
pizzolo.com uses an invalid security certificate.
The certificate is not trusted because the issuer certificate is unknown.
The server might not be sending the appropriate intermediate certificates.
An additional root certificate may need to be imported.
The certificate is not valid for domain pizzolo.com.
The certificate expired on Wednesday March 31. 2010 HH:MM. The current time is Friday August 21. XX:YY

There also used to be a dialogue that listed all the issues by severity, found a picture of it here: https://becomethesolution.com/images/easyblog_articles/1191/b2ap3_large_firefox-confirm-security-exception.png

Regarding the priority of SHA1 vs unknown issuers - I believe "unknown issuer" should definitely have the priority.
If you have control over "the unknown authority", you can easily make it SHA1 (or expired) and try to hide behind a misleading error.

You need to log in before you can comment on or make changes to this bug.