1304133 - Explicitly list selfhosted.js as an output for embedjs.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

embedjs.py creates both selfhosted.out.h and selfhosted.js, so we should specify them both as outputs in moz.build.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1304133 - explicitly list selfhosted.js output in GENERATED_FILES;

Review commit: https://reviewboard.mozilla.org/r/79826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79826/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8793014 [details]
Bug 1304133 - explicitly list selfhosted.js output in GENERATED_FILES;

https://reviewboard.mozilla.org/r/79826/#review78644

I seem to remember selfhosted.js isn't used anywhere, which might explain why it isn't mentioned here. Is there some advantage to listing it?

Comment 3

[Michael Shal [:mshal]]

(In reply to Chris Manchester (:chmanchester) from comment #2)
> I seem to remember selfhosted.js isn't used anywhere, which might explain
> why it isn't mentioned here.

Do you recall where you heard that, or who I can ask about it? If it isn't used, I'd rather change embedjs.py to stop generating it.

> Is there some advantage to listing it?

The tup backend checks that the process only writes to the files that we said it was going to write to in order to make sure the dependencies are correct. So if we don't list it, tup complains.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I concluded this by reading the code, I could be mistaken. Maybe Till can comment on this. 

Do we need to output selfhosted.js in addition to selfhosted.out.h? It does not appear to be incorporated into the build.

Comment 5

[Till Schneidereit [:till]]

It'be quite unfortunate not to have this anymore: internal JS errors happening in self-hosted code show up as things like "selfhosted:1234". It's hard to impossible to directly map them to original source files, so looking at selfhosted.js is the only useful recourse.

Comment 6

[Michael Shal [:mshal]]

Ahh, good to know - thanks! I'll stick with the original patch then, which just informs the build system that the file will be created.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f866a7b1db4
explicitly list selfhosted.js output in GENERATED_FILES; r=chmanchester

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f866a7b1db4