1304136 - AccEventGen.py should re-use xpidllex.py / xpidlyacc.py from header.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

This script currently creates its own xpidllex.py / xpidlyacc.py, in addition to the .h & .cpp file. We should just reuse the ones from the header.py action.

Also since we support multiple outputs in GENERATED_FILES now, they can be combined into a single script invocation.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1304136 - have AccEventGen.py re-use xpidllex.py / xpidlyacc.py;

Review commit: https://reviewboard.mozilla.org/r/79820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79820/

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1304136 - Use a single AccEventGen.py invocation;

Review commit: https://reviewboard.mozilla.org/r/79822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79822/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8793012 [details]
Bug 1304136 - have AccEventGen.py re-use xpidllex.py / xpidlyacc.py;

https://reviewboard.mozilla.org/r/79820/#review78638

::: accessible/xpcom/moz.build:62
(Diff revision 1)
> -xpc_acc_events_h.inputs += ['AccEvents.conf']
> +xpc_acc_events_h.inputs += ['AccEvents.conf', '!/xpcom/idl-parser/xpidl/xpidllex.py', '!/xpcom/idl-parser/xpidl/xpidlyacc.py']
>  
>  xpc_acc_events_cpp = GENERATED_FILES['xpcAccEvents.cpp']
>  xpc_acc_events_cpp.script = 'AccEventGen.py:gen_cpp_file'
> -xpc_acc_events_cpp.inputs += ['AccEvents.conf']
> +xpc_acc_events_cpp.inputs += ['AccEvents.conf', '!/xpcom/idl-parser/xpidl/xpidllex.py', '!/xpcom/idl-parser/xpidl/xpidlyacc.py']

Adding extra inputs just to get dependecies right is unfortunate, but I can see we don't have much of a choice here.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8793013 [details]
Bug 1304136 - Use a single AccEventGen.py invocation;

https://reviewboard.mozilla.org/r/79822/#review78642

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/570eff59efda
have AccEventGen.py re-use xpidllex.py / xpidlyacc.py; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/11253b3b99b4
Use a single AccEventGen.py invocation; r=chmanchester

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/570eff59efda
https://hg.mozilla.org/mozilla-central/rev/11253b3b99b4