Closed Bug 1304136 Opened 8 years ago Closed 8 years ago

AccEventGen.py should re-use xpidllex.py / xpidlyacc.py from header.py

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(2 files)

This script currently creates its own xpidllex.py / xpidlyacc.py, in addition to the .h & .cpp file. We should just reuse the ones from the header.py action.

Also since we support multiple outputs in GENERATED_FILES now, they can be combined into a single script invocation.
Comment on attachment 8793012 [details]
Bug 1304136 - have AccEventGen.py re-use xpidllex.py / xpidlyacc.py;

https://reviewboard.mozilla.org/r/79820/#review78638

::: accessible/xpcom/moz.build:62
(Diff revision 1)
> -xpc_acc_events_h.inputs += ['AccEvents.conf']
> +xpc_acc_events_h.inputs += ['AccEvents.conf', '!/xpcom/idl-parser/xpidl/xpidllex.py', '!/xpcom/idl-parser/xpidl/xpidlyacc.py']
>  
>  xpc_acc_events_cpp = GENERATED_FILES['xpcAccEvents.cpp']
>  xpc_acc_events_cpp.script = 'AccEventGen.py:gen_cpp_file'
> -xpc_acc_events_cpp.inputs += ['AccEvents.conf']
> +xpc_acc_events_cpp.inputs += ['AccEvents.conf', '!/xpcom/idl-parser/xpidl/xpidllex.py', '!/xpcom/idl-parser/xpidl/xpidlyacc.py']

Adding extra inputs just to get dependecies right is unfortunate, but I can see we don't have much of a choice here.
Attachment #8793012 - Flags: review?(cmanchester) → review+
Comment on attachment 8793013 [details]
Bug 1304136 - Use a single AccEventGen.py invocation;

https://reviewboard.mozilla.org/r/79822/#review78642
Attachment #8793013 - Flags: review?(cmanchester) → review+
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/570eff59efda
have AccEventGen.py re-use xpidllex.py / xpidlyacc.py; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/11253b3b99b4
Use a single AccEventGen.py invocation; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/570eff59efda
https://hg.mozilla.org/mozilla-central/rev/11253b3b99b4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: