[gofaster] Pocket update for fx50 part 3 locale updates

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Depends on 3 bugs)

50 Branch
Firefox 52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50+ fixed, firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1304142 added code changes and early updates to l10n for the addon.  This part 3 patch will be any later stage l10n updates that need to be uplifted.  Since they will be locale additions only, it should represent minimal risk for uplift to beta later in the cycle.
(Assignee)

Updated

3 years ago
Assignee: nobody → mixedpuppy
(Assignee)

Comment 1

3 years ago
[Tracking Requested - why for this release]: This is the last part of the pocket update and will primarily contain locales finished in pontoon that were not in bug 1304142, which was landed early to get code changes uplifted early.
(Assignee)

Comment 2

3 years ago
[Tracking Requested - why for this release]: selected wrong version before, see comment #1
(Assignee)

Comment 3

3 years ago
Looking at Pontoon, I feel we're at a pretty good place to call it a day for Fx50, so I'm going to post a patch for review.  Flod, if you feel differently, let me know.  We can always continue to land new locales on central.
Flags: needinfo?(francesco.lodolo)
Comment hidden (mozreview-request)

Comment 5

3 years ago
mozreview-review
Comment on attachment 8795857 [details]
Bug 1304151 add finished locales and a couple minor bug fixes,

https://reviewboard.mozilla.org/r/81826/#review80428

r=me on code, I assume flod can r+ the l10n
Attachment #8795857 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 6

3 years ago
mozreview-review
Comment on attachment 8795857 [details]
Bug 1304151 add finished locales and a couple minor bug fixes,

https://reviewboard.mozilla.org/r/81826/#review80530

::: browser/extensions/pocket/locale/jar.mn:29
(Diff revision 1)
>  [features/firefox@getpocket.com] @AB_CD@.jar:
>  % locale pocket @AB_CD@ %locale/@AB_CD@/
>    # For locales we support, include the file from the locale's directory in the
>    # source tree.
>    # For other locales (and en-US) fallback to the en-US directory.
> -#if AB_CD == ast || AB_CD == az || AB_CD == bg || AB_CD == bn_BD || AB_CD == cs || AB_CD == da || AB_CD == de || AB_CD == dsb || AB_CD == en_US || AB_CD == es_CL || AB_CD == es_ES || AB_CD == es_MX || AB_CD == et || AB_CD == fi || AB_CD == fr || AB_CD == fy_NL || AB_CD == hr || AB_CD == hsb || AB_CD == hu || AB_CD == it || AB_CD == ja || AB_CD == kab || AB_CD == lv || AB_CD == nl || AB_CD == nn_NO || AB_CD == or || AB_CD == pt_BR || AB_CD == pt_PT || AB_CD == rm || AB_CD == ro || AB_CD == ru || AB_CD == sk || AB_CD == sl || AB_CD == sq || AB_CD == sr || AB_CD == sv_SE || AB_CD == te || AB_CD == th || AB_CD == tr || AB_CD == uk || AB_CD == zh_CN || AB_CD == zh_TW
> +#if AB_CD == ast || AB_CD == az || AB_CD == bg || AB_CD == bn_BD || AB_CD == cs || AB_CD == da || AB_CD == de || AB_CD == dsb || AB_CD == en_GB || AB_CD == en_US || AB_CD == es_AR || AB_CD == es_CL || AB_CD == es_ES || AB_CD == es_MX || AB_CD == et || AB_CD == fi || AB_CD == fr || AB_CD == fy_NL || AB_CD == gu_IN || AB_CD == hr || AB_CD == hsb || AB_CD == hu || AB_CD == it || AB_CD == ja || AB_CD == ka || AB_CD == kab || AB_CD == lt || AB_CD == lv || AB_CD == mr || AB_CD == ms || AB_CD == nl || AB_CD == nn_NO || AB_CD == or || AB_CD == pt_BR || AB_CD == pt_PT || AB_CD == rm || AB_CD == ro || AB_CD == ru || AB_CD == sk || AB_CD == sl || AB_CD == sq || AB_CD == sr || AB_CD == sv_SE || AB_CD == te || AB_CD == th || AB_CD == tr || AB_CD == uk || AB_CD == zh_CN || AB_CD == zh_TW

You need to add pl, which is complete but not available on Pontoon (long story).

https://l10n.mozilla-community.org/webstatus/?product=pocket
Attachment #8795857 - Flags: review?(francesco.lodolo)
(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> Looking at Pontoon, I feel we're at a pretty good place to call it a day for
> Fx50, so I'm going to post a patch for review.  Flod, if you feel
> differently, let me know.  We can always continue to land new locales on
> central.

We might want to check from time to time if there are more locales to add, but I think we're in a good place for now.
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 8

3 years ago
(In reply to Francesco Lodolo [:flod] from comment #6)
> You need to add pl, which is complete but not available on Pontoon (long
> story).
> 
> https://l10n.mozilla-community.org/webstatus/?product=pocket

Where do I find pocket.properties for pl?  How will we deal with this going forward?
It's in the same place as the other locales, just not listed in Pontoon.
https://github.com/mozilla-l10n/pocket-l10n/tree/master/locales/pl

At some point we'll enable all projects for all locales on Pontoon (single dashboard), but it's going to take a while. 
In the meantime, you can use https://l10n.mozilla-community.org/webstatus/?product=pocket, or even its API (we plan to add API to Pontoon too, bug 1302053)
https://l10n.mozilla-community.org/webstatus/api/?product=pocket&type=complete&txt
Comment hidden (mozreview-request)

Comment 11

3 years ago
mozreview-review
Comment on attachment 8795857 [details]
Bug 1304151 add finished locales and a couple minor bug fixes,

https://reviewboard.mozilla.org/r/81826/#review80544
Attachment #8795857 - Flags: review+

Comment 12

3 years ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d4e7f3917d2f
add finished locales and a couple minor bug fixes, r=flod,Gijs

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4e7f3917d2f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
(Assignee)

Comment 14

3 years ago
Comment on attachment 8795857 [details]
Bug 1304151 add finished locales and a couple minor bug fixes,

Approval Request Comment
[Feature/regressing bug #]:pocket update
[User impact if declined]:for users a few less locales covered, for pocket, a couple minor code changes that affect the a/b testing.
[Describe test coverage new/current, TreeHerder]:none
[Risks and why]: low
[String/UUID change made/needed]:N/A for pocket

This is the wrap-up for Beta 50 uplifts for pocket.
Attachment #8795857 - Flags: approval-mozilla-beta?
Attachment #8795857 - Flags: approval-mozilla-aurora?
Comment on attachment 8795857 [details]
Bug 1304151 add finished locales and a couple minor bug fixes,

Planned pocket update, Aurora51+, Beta50+
Attachment #8795857 - Flags: approval-mozilla-beta?
Attachment #8795857 - Flags: approval-mozilla-beta+
Attachment #8795857 - Flags: approval-mozilla-aurora?
Attachment #8795857 - Flags: approval-mozilla-aurora+
Hi Florin, there is a planned update to Pocket system add-on update in 50. Is this something your team is already planning to test?
Flags: needinfo?(florin.mezei)
(In reply to Ritu Kothari (:ritu) from comment #16)
> Hi Florin, there is a planned update to Pocket system add-on update in 50.
> Is this something your team is already planning to test?

Hey Ritu, yes, we've already spoken with Shane about this and started updating our tests to target these changes as well -- Paul is working on this as we speak.

(redirecting the ni? to myself as a reminder)
Flags: needinfo?(florin.mezei) → needinfo?(andrei.vaida)
QA Contact: paul.silaghi
I'm planning to run some smoke tests on the basic Pocket functionality, now that the updates part 3 are out. Will also include the 3 variation of the experiment in our testing as well.
Shane, considering the part 3 is related to locale updates, should we also focus on some locales testing?
Also, are there any plans to release Pocket update part 4 in the near future?
Flags: needinfo?(andrei.vaida) → needinfo?(mixedpuppy)
(Assignee)

Comment 21

3 years ago
(In reply to Paul Silaghi, QA [:pauly] from comment #20)
> I'm planning to run some smoke tests on the basic Pocket functionality, now
> that the updates part 3 are out. Will also include the 3 variation of the
> experiment in our testing as well.

The variation bug you ran into in part 2 is fixed by part 3 [here], and the weighting is changing with bug 1309027.  I wouldn't worry about trying to test the weighting, leave that to pocket.

> Shane, considering the part 3 is related to locale updates, should we also
> focus on some locales testing?

You can certainly do some locales testing if you want, here's the locales that are supported:
https://dxr.mozilla.org/mozilla-central/source/browser/extensions/pocket/locale

> Also, are there any plans to release Pocket update part 4 in the near future?

There wasn't but yesterday another update was started in bug 1309027
Flags: needinfo?(mixedpuppy)
(Assignee)

Updated

3 years ago
Blocks: 1309027
Depends on: 1310723
Depends on: 1310928
You need to log in before you can comment on or make changes to this bug.