1304168 - JavaScript Error: "TypeError: aBrowser.removeListener is not a function" (SessionStore.js" line: 571)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Really stupid error, and this totally breaks the session store, inluding the restoring of zombified tabs.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1304168 - Use correct function name to remove event listener.

Review commit: https://reviewboard.mozilla.org/r/79854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79854/

Comment 2

[Jan Henning [:JanH]]

Comment on attachment 8793040 [details]
Bug 1304168 - Use correct function name to remove event listener.

Approval Request Comment
[Feature/regressing bug #]: Bug 1301016
[User impact if declined]: Not necessarily user visible, but an uncaught exception in the session store should still best be avoided to avoid any nasty side effects.t
[Describe test coverage new/current, TreeHerder]: Existing tests should catch total breakage, but some subtle errors in session store behaviour might get through.
[Risks and why]: No - that line is already broken.
[String/UUID change made/needed]: none

Comment 3

[Jan Henning [:JanH]]

Actually I'm not sure whether the broken session store behaviour is related to this, because I cannot reproduce those side effects on a second attempt, but this needs fixing anyway.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This needs r+ in MozReview before autoland can do anything with it.

Comment 5

[Jan Henning [:JanH]]

Comment on attachment 8793040 [details]
Bug 1304168 - Use correct function name to remove event listener.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79854/diff/1-2/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8793040 [details]
Bug 1304168 - Use correct function name to remove event listener.

https://reviewboard.mozilla.org/r/79854/#review79042

Drive-by review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/639092fd692d
Use correct function name to remove event listener. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/639092fd692d

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8793040 [details]
Bug 1304168 - Use correct function name to remove event listener.

Fixes a recent regression with SessionRestore with ReaderMode on, Aurora51+, Beta50+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2e563430180

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/73430b7a19da

Comment 12

[Mira Lobontiu (Android QA)]

Hi,

Is the qe-verify+ flag still valid?

Thanks!

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Redirect to Ioana.

Comment 14

[Ioana Chiorean]

This was not reproduced in the last couple of years. I think we can take it out - Jan would have followed up with it would have not been fixed. 
Thanks Mira and Ritu for the follow up!