[EME] Implement MediaKeySession.onkeystatuseschange

RESOLVED FIXED in Firefox 52

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpearce, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This Web Platform test is failing because we don't implement MediaKeySession.onkeystatuseschange:

https://w3c-test.org/encrypted-media/idlharness.html

Should be an easy fix.
(Reporter)

Updated

a year ago
Priority: -- → P3
(Reporter)

Comment 1

a year ago
Specification:
https://w3c.github.io/encrypted-media/#dom-mediakeysession-onkeystatuseschange
Summary: Implement MediaKeySession.onkeystatuseschange → [EME] Implement MediaKeySession.onkeystatuseschange
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8793143 [details]
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange.

https://reviewboard.mozilla.org/r/79930/#review78766

::: dom/media/eme/MediaKeySession.cpp:495
(Diff revision 1)
> +  return elm ? elm->GetEventHandler(nsGkAtoms::onkeystatuseschange, EmptyString())
> +             : nullptr;
> +}
> +
> +void
> +MediaKeySession::SetOnkeystatuseschange(EventHandlerNonNull* handler)

aHandler or aCallback

::: dom/media/eme/MediaKeySession.cpp:499
(Diff revision 1)
> +void
> +MediaKeySession::SetOnkeystatuseschange(EventHandlerNonNull* handler)
> +{
> +  EventListenerManager *elm = GetOrCreateListenerManager();
> +  if (elm) {
> +    elm->SetEventHandler(nsGkAtoms::onkeystatuseschange, EmptyString(), handler);

As I mentioned in the other bug, Get/SetEventHandler is handy for this case.

Comment 4

a year ago
mozreview-review
Comment on attachment 8793143 [details]
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange.

https://reviewboard.mozilla.org/r/79930/#review78768
Attachment #8793143 - Flags: review?(bugs) → review+
(Reporter)

Comment 5

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9773f974a447c5f37789505e457e708a810631d
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange. r=smaug

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9773f974a44
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9773f974a44
You need to log in before you can comment on or make changes to this bug.