1304249 - [EME] Implement MediaKeySession.onkeystatuseschange

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

This Web Platform test is failing because we don't implement MediaKeySession.onkeystatuseschange:

https://w3c-test.org/encrypted-media/idlharness.html

Should be an easy fix.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Specification:
https://w3c.github.io/encrypted-media/#dom-mediakeysession-onkeystatuseschange

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1304249 - Implement MediaKeySession.onkeystatuseschange.

Review commit: https://reviewboard.mozilla.org/r/79930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79930/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8793143 [details]
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange.

https://reviewboard.mozilla.org/r/79930/#review78766

::: dom/media/eme/MediaKeySession.cpp:495
(Diff revision 1)
> +  return elm ? elm->GetEventHandler(nsGkAtoms::onkeystatuseschange, EmptyString())
> +             : nullptr;
> +}
> +
> +void
> +MediaKeySession::SetOnkeystatuseschange(EventHandlerNonNull* handler)

aHandler or aCallback

::: dom/media/eme/MediaKeySession.cpp:499
(Diff revision 1)
> +void
> +MediaKeySession::SetOnkeystatuseschange(EventHandlerNonNull* handler)
> +{
> +  EventListenerManager *elm = GetOrCreateListenerManager();
> +  if (elm) {
> +    elm->SetEventHandler(nsGkAtoms::onkeystatuseschange, EmptyString(), handler);

As I mentioned in the other bug, Get/SetEventHandler is handy for this case.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8793143 [details]
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange.

https://reviewboard.mozilla.org/r/79930/#review78768

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9773f974a447c5f37789505e457e708a810631d
Bug 1304249 - Implement MediaKeySession.onkeystatuseschange. r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9773f974a44

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9773f974a44