1304262 - Codemirror dialog does not work in inspector and scratchpad

Status: VERIFIED FIXED

(DevTools :: Source Editor, defect, P1)

Description

[[e-mail]]

STR:

* Open inspector in nightly, press Ctrl+J make current window focus to elsewhere

* Open inspector in 50a2, press Ctrl+J will show an commandline at the top of codemirror window for input line number

Same as find(Ctrl+F), find again(Ctrl+G)

Comment 1

[[e-mail]]

scratchpad is affected as well

update: find again(Ctrl+G) works

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=7e873393cc11d326338779e5a3ed2da031e30936&tochange=8d2a514d0f23060d95b4f705c98ed37baff46422

Regressed by: 8d2a514d0f23	Brian Grinstead — Bug 1301790 - Bundle codemirror into a single script;r=gl

Comment 3

[[e-mail]]

Thanks for locate the regression window!

I found `dialog.css` is removed in jar.mn, which makes the dialog UI invisible to user

content/sourceeditor/codemirror/addon/dialog/dialog.css (sourceeditor/codemirror/addon/dialog/dialog.css)

Comment 4

[[e-mail]]

Attachment: Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

Review commit: https://reviewboard.mozilla.org/r/80318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80318/

Comment 5

[[e-mail]]

The patch also moved babel settings into package.json as described in bug 1301790 comment 9

Ref: https://babeljs.io/docs/usage/babelrc/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

https://reviewboard.mozilla.org/r/80318/#review78982

R+, Thank you for the patch!

Comment 7

[[e-mail]]

thanks

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until it's marked as r+ in MozReview.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

https://reviewboard.mozilla.org/r/80318/#review79122

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

I am not quite sure what the problem is since it is already marked as r+ in MozReview

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

https://reviewboard.mozilla.org/r/80318/#review79126

Comment 12

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

https://reviewboard.mozilla.org/r/80318/#review79128

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

https://reviewboard.mozilla.org/r/80318/#review79130

Comment 14

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/fx-team/rev/d6103dea7601d9bae093847ef2b234697d923552
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad; r=gl

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6103dea7601

Comment 16

[[e-mail]]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

Approval Request Comment
[Feature/regressing bug #]: bug 1301790
[User impact if declined]: No find/jump dialog in scratchpad & debugger
[Describe test coverage new/current, TreeHerder]: green
[Risks and why]: minor, only add missing css in jar.mn
[String/UUID change made/needed]: N

Comment 17

[Gerry Chang [:gchang]]

Comment on attachment 8793605 [details]
Bug 1304262 - codemirror dialog does not work in inspector and scratchpad;

This patch fixes a regression. Take it in 51 aurora.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f50f2ef1ee1

Comment 19

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 52.0a1, build ID:20160920030429, on Windows 10 x64.

I verified the fix using Fx52.0a1, build ID: 20160928030201 and Fx 51.0a2, build ID: 20160928004008, on Windows 10 x64.

If opening the inspector and pressing Ctrl + J the library is opened, on both nightly and aurora, however in scratchpad the issue is fixed.

Should I log a new bug with this issue?

Comment 20

[[e-mail]]

Christian, 

To test CodeMirror in inspector, you have to

1. open inspector panel
2. hover on any line of code and right click to open the context menu
3. select 'edit HTML' to open the embeded CodeMirror editor
4. press Ctrl+J inside the editor and check if jumpToLine dialog is shown

Comment 21

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you for the details! 
I verified on the latest nightly and latest aurora, the issue is fixed.
Cheers!

Comment 22

[[e-mail]]

thanks for your help :)