1304297 - Cache storage can't be deleted in the storage panel

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Patrick Brosset <:pbro>]

See this tweet: https://twitter.com/MoOx/status/778474272427745280
We have implemented delete in the storage panel for several storage types, but not for Cache storage yet. As a result it's not possible to clear the items put in cache by a service worker.

This require implementing the right actor delete method, and adding the right context menus in the UI to allow for deletion.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

FWIW, it would be nice to have delete at the Request/Response level and also at the Cache object level.

Comment 2

[Jarda Snajdr [:jsnajdr]]

Attachment: Bug 1304297 - Support for deleting Cache and Response objects in Storage Inspector

Review commit: https://reviewboard.mozilla.org/r/80406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80406/

Comment 3

[Jarda Snajdr [:jsnajdr]]

Added support for:
- deleting cache Response objects from the storage table
- deleting Cache objects from the storage tree
- "delete all" - clear all responses in a Cache, in both tree and the table

In the frontend, I renamed the "removeDatabase" method (and the menu items) to more general "removeTreeItem", as it can remove Caches now, too.

This means that the delete support in Cache is complete - everything deletable can be deleted now :)

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8793709 [details]
Bug 1304297 - Support for deleting Cache and Response objects in Storage Inspector

https://reviewboard.mozilla.org/r/80406/#review79046

Great work... and really fast.

We should run this through try before we land it though.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=188c714c1d66f5a7afe7cb2764d2472957258efa

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c437117dafa
Support for deleting Cache and Response objects in Storage Inspector r=miker

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c437117dafa

Comment 8

[Surentharan]

[bugday-20170215]