1304315 - [Pointer Event] Make all pointer events's default width/height to 1

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Ming-Chou Shih [:stone]]

Follow [1] to set width/height to 1

[1] https://w3c.github.io/pointerevents/#pointerevent-interface

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] Make all pointer events's default width/height to 1 (V1)

Comment 3

[Ming-Chou Shih [:stone]]

Comment on attachment 8793603 [details] [diff] [review]
[Pointer Event] Make all pointer events's default width/height to 1 (V1)

Spec says the default width and height of pointer events should be 1. Created a patch to set the default values and enabled related test cases.

Comment 4

[Ming-Chou Shih [:stone]]

Attachment: Bug 1304315 - [Pointer Event] Make all pointer events's default width/height to 1. f=bevistseng. r=masayuki.

Updated the patch summary

Comment 5

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f12a9d2f06f682cef45fae50fb46bcb0cd77e51

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: Bug 1304315 - [Pointer Event] Make all pointer events's default width/height to 1. f=bevistseng. r=masayuki. (V3)

Refined patch to keep perference setting in pointerevent_constructor.html.ini

Comment 7

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb6db7ea36e9f7d2e25b960811122f6d288ab1b5

Comment 8

[Carsten Book [:Tomcat]]

needs dom peer review:

WebIDL file dom/webidl/PointerEvent.webidl altered in changeset 008a709b5458 without DOM peer review

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Bug 1304315 - [Pointer Event] Make all pointer events's default width/height to 1. f=bevistseng. r=smaug,masayuki. (V4)

Updated the patch summary.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0edddcd4c24b
[Pointer Event] Make all pointer events's default width/height to 1. f=bevistseng. r=smaug,masayuki.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0edddcd4c24b

Comment 12

[Chris Mills [:cmills]]

I have make sure this change is documented in the following pages:
https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/PointerEvent
https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/width
https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/height

I have also added a note to the Fx52 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if this looks OK. Thanks!