1304316 - Intermittent python/mozbuild/mozbuild/test/frontend/test_emitter.py | TestEmitterBasic.test_test_manifest_shared_support_files, line 474: Items in the second set but not the first

Status: NEW

(Firefox Build System :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to Chris Manchester (:chmanchester) from bug 1302364 comment #16)
> It looks like that test is relying on an unstable ordering (it's based on
> the keys of a dict, which I must not have realized when writing that test),
> so modifying the source dict created a spurious error.
> 
> Feel free to disable that test for now, and please file a follow up so we
> can get it fixed.

Failure details:

 0:33.99 TEST-UNEXPECTED-FAIL | /Volumes/data/code/gecko/python/mozbuild/mozbuild/test/frontend/test_emitter.py | TestEmitterBasic.test_test_manifest_shared_support_files, line 474: Items in the second set but not the first:
 0:33.99 FAIL: Support files starting with '!' are given separate treatment, so their
 0:33.99 Traceback (most recent call last):
 0:33.99   File "/Volumes/data/code/gecko/python/mozbuild/mozbuild/test/frontend/test_emitter.py", line 474, in test_test_manifest_shared_support_files
 0:33.99     expected_deferred_installs)
 0:33.99 AssertionError: Items in the second set but not the first:
 0:33.99 u'!/child/data/**'
 0:33.99 u'!/child/another-file.sjs'
 0:33.99 u'!/child/test_sub.js'

https://dxr.mozilla.org/mozilla-central/rev/fd0564234eca242b7fb753a110312679020f8059/python/mozbuild/mozbuild/test/frontend/test_emitter.py#459

So I checked what supported and child contain as deferred_installs.

Here without my changes:
supported: set(['!/child/data/**', '!/child/another-file.sjs', '!/child/test_sub.js'])
child: set([])

And with my changes:
supported: set([])
child: set(['!/child/data/**', '!/child/another-file.sjs', '!/child/test_sub.js'])

So it's vise-versa now.