1304379 - Add-on panel size increases each time the add-on button is clicked

Status: VERIFIED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: my_jetpack_addon-0.0.2-an+fx.xpi

[Note]
This is a follow-up bug for Bug 1294199

[Affected versions]:
Firefox 52.0a1 (2016-09-20)
Firefox 51.0a2 (2016-09-21)
Firefox 50.0b1 (20160920155715)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.10.4

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Install the attached add-on.
3.Click multiple times on the add-on icon from toolbar.

[Expected results]:
The panel size remains the same and it does not modify when the add-on button is clicked.


[Actual results]:
The add-on panel size increases each time it is opened and closed by clicking on the toolbar icon: http://screencast.com/t/ipND2rKxsqt

[Regression range]:
Last good revision: e3fa462347c8c863e310d4e0e45e470c9775bdcd
First bad revision: 1430290455ed94109e973fd17c7f62865e1695c9
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e3fa462347c8c863e310d4e0e45e470c9775bdcd&tochange=1430290455ed94109e973fd17c7f62865e1695c9


[Additional notes]:
- This issue is not reproducible on Ubuntu 16.04 32-bit.
- I am attaching the add-on.

Comment 1

[Kris Maglione [:kmag]]

Do you see any errors in the Browser Console when this happens?

Comment 3

[Vasilica Tamas, QA [:vtamas]]

(In reply to Kris Maglione [:kmag] from comment #1)
> Do you see any errors in the Browser Console when this happens?

I’m only seeing     NS_ERROR_NOT_IMPLEMENTED:  utils.js:92      while clicking in Private Mode, but this issue is also reproducible in a normal window.

Comment 4

[Kris Maglione [:kmag]]

Interesting. I can't reproduce this on Firefox 52 32bit on Windows 7...

Comment 5

[Kris Maglione [:kmag]]

Or 64bit Firefox 52 on Windows 7.

Comment 6

[Kris Maglione [:kmag]]

Ah, I understand what's happening now. This only happens if I click on the toolbar button to dismiss the panel. In that case, your onClick listener calls `show()` again, and `show()` winds up appending another browser to the panel, even though one already exists.

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1304379: Don't create an extra browser if panel.show is called multiple times.

Review commit: https://reviewboard.mozilla.org/r/81838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81838/

Comment 8

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8795886 [details]
Bug 1304379: Don't create an extra browser if panel.show is called multiple times.

https://reviewboard.mozilla.org/r/81838/#review80954

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d89bdc2d9f01f68fa74781e57ab582b15c2738a7
Bug 1304379: Don't create an extra browser if panel.show is called multiple times. r=gabor

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 8795886 [details]
Bug 1304379: Don't create an extra browser if panel.show is called multiple times.

Approval Request Comment
[Feature/regressing bug #]: Bug 1294199
[User impact if declined]: This bug causes significant UI issues in SDK panels that are implemented in certain ways that persist until browser restart.
[Describe test coverage new/current, TreeHerder]: The panel code that this affects is generally well-tested. There is still no automated test for this particular corner case.
[Risks and why]: Very low. This patch simply adds a conditional which prevents an additional <browser> element from being inserted, and the reference to the existing one from being overwritten, when it's not necessary.
[String/UUID change made/needed]: None.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8795886 [details]
Bug 1304379: Don't create an extra browser if panel.show is called multiple times.

Simple fix, Aurora51+, Beta50+

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d89bdc2d9f01

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1341ec6ae014

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e8610794c397

Comment 15

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 52.0a1 (2016-09-21) under Windows 10 64-bit.

Tested on Firefox 52.0a1 (2016-10-04), Firefox 51.0a2 (2016-10-04) and Firefox 50.0b4 (20161003155957) and I confirm that the panel does no longer modify its size each time the add-on button is clicked. 

I’ve also noticed that on Nightly the panel is never closed and is continuously opened when clicking the icon: http://screencast.com/t/8PS5N2QM0qJh  (compared with DevEdition and Beta where the panel is closed when the button is clicked a second time: http://screencast.com/t/AAJXjKBp) 

Kris, what do you think? Should I reopen this bug or file a new one?

Comment 16

[Kris Maglione [:kmag]]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #15)
> I’ve also noticed that on Nightly the panel is never closed and is
> continuously opened when clicking the icon:
> http://screencast.com/t/8PS5N2QM0qJh  (compared with DevEdition and Beta
> where the panel is closed when the button is clicked a second time:
> http://screencast.com/t/AAJXjKBp) 
> 
> Kris, what do you think? Should I reopen this bug or file a new one?

This is an issue with the add-on itself, so it doesn't need a bug.

Comment 17

[Vasilica Tamas, QA [:vtamas]]

(In reply to Kris Maglione [:kmag] from comment #16)

> This is an issue with the add-on itself, so it doesn't need a bug.

Thanks Kris! 

Based on Comment 15 and Comment 16 I am marking this bug as Verified.