1304395 - Add missing feature flags for new 6.0 features and disable on master

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Stephan Leroux [:sleroux]]

In hopes of stabilizing our master branch from all the new feature work we've landed, we should:

1. Find any new features which are missing a feature flag and put them behind one.
2. Disable unstable features for later testing when the team has more bandwidth.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2109#attch-to-bugzilla

Found a few feature that needed wrapping and backed out one. If we truly want to make 6.0 a featureless release, the atomic uploads code is on master and is something we can't feature flag-ify so we can either back it out now or let it ride in beta to see how it goes. I'd be tempted to let it ride and if there are any issues to just back it out.

Comment 2

[Farhan Patel [:farhan]]

Comment on attachment 8793419 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2109#attch-to-bugzilla

I left a small comment. But otherwise, Awesome! I agree with disabling the URL scrolling stuff. It's nice, but I've been seeing some wonkyness myself with it. Best to disable for now.

Comment 3

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla/firefox-ios/commit/b7fdb7f0527effb3a7905fc49d2bbd8206e11852