1304415 - Linking against .dylibs in our Shared target is unsafe for application extensions

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Stephan Leroux [:sleroux]]

Shared is used across all extensions and has the 'Allow app extension API only' which is good but the compiler complains about the .dylibs we link into it since loading these in the context of an extension is unsafe:

linking against a dylib which is not safe for use in application extensions: /Users/sleroux/development/firefox-ios/Carthage/Build/iOS/GCDWebServers.framework/GCDWebServers

linking against a dylib which is not safe for use in application extensions: /Users/sleroux/development/firefox-ios/Carthage/Build/iOS/GCDWebServers.framework/GCDWebServers

If we turn this off, all of the extensions will complain that Shared is unsafe to link since it doesn't restrict its use to extension-friendly APIs. We should evaluate what each extension needs from the Shared library. From there, we should either descope the use of Shared or factor out the unsafe uses of the .dylibs into another target that we exclude from the extensions.