Make incompatible mozharness actions a no-op when try syntax includes '--artifact'

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: maja_zf, Unassigned)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Bug 1278698 clears volatile config to ignore command-line actions in favour of default actions from the mozharness config for artifact builds. This can be confusing.

https://dxr.mozilla.org/mozilla-central/rev/62f79d676e0e11b3ad59a5425b3ebb3ec5bbefb5/testing/mozharness/scripts/fx_desktop_build.py#155-157

A better solution may be to check for the "forced artifact" status in self.config to make incompatible actions a no-op. That way we effectively skip these actions even if they're specified at the command-line.

Comment 1

3 years ago
Thanks Maja!
It will probably be helpful to do a self.info("Skipping ACTION because this is an artifact build...") before the return, so people know why it's being skipped.

Comment 2

3 years ago
Can we add red ink and blinking letters? :D
Thanks Maja!
Calling the mozharness script with action options like |--get-secrets --build --check-test --generate-build-stats|, which is what the TC build task does, means that *only* those actions will run. So in addition to skipping incompatible actions specified in the TC task command-line args, we need to run all the actions from default_actions in the artifact build config. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8612d7245520801c7c2c2e916b130ccac704d1d
Comment hidden (mozreview-request)

Comment 5

3 years ago
mozreview-review
Comment on attachment 8796687 [details]
Bug 1304487 - Make incompatible mozharness actions a no-op when try syntax includes '--artifact';

https://reviewboard.mozilla.org/r/82450/#review81082
Attachment #8796687 - Flags: review?(armenzg) → review+

Comment 6

3 years ago
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/61d4d0b94315
Make incompatible mozharness actions a no-op when try syntax includes '--artifact'; r=armenzg

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61d4d0b94315
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.