Stop using pymake in mozharness

RESOLVED FIXED in Firefox 55

Status

()

Core
Build Config
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Assignee)

Description

a year ago
mozharness is currently using pymake to execute `make check` on Windows. Why, I don't know. Probably a relic from an ancient era. We should have it use `mach` to run the "check" target.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8793495 - Flags: review?(cmanchester)
(Assignee)

Comment 4

a year ago
mozreview-review
Comment on attachment 8793495 [details]
Bug 1304508 - Use mach for running "check" target;

https://reviewboard.mozilla.org/r/80220/#review78942

OS X builds broke because of this. Apparently mach doesn't think we have a full build environment. Probably due to universal builds blowing away state or something.

Comment 5

a year ago
mozreview-review
Comment on attachment 8793494 [details]
Bug 1304508 - Support passing --keep-going to make;

https://reviewboard.mozilla.org/r/80218/#review79284
Attachment #8793494 - Flags: review?(cmanchester) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Attachment #8793495 - Flags: review?(cmanchester)
(Assignee)

Comment 8

9 months ago
Try push had some failures on Windows.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 14

9 months ago
mozreview-review
Comment on attachment 8793494 [details]
Bug 1304508 - Support passing --keep-going to make;

https://reviewboard.mozilla.org/r/80218/#review138066
Attachment #8793494 - Flags: review?(ted) → review+

Comment 15

9 months ago
mozreview-review
Comment on attachment 8793495 [details]
Bug 1304508 - Use mach for running "check" target;

https://reviewboard.mozilla.org/r/80220/#review138068
Attachment #8793495 - Flags: review?(ted) → review+

Comment 16

9 months ago
mozreview-review
Comment on attachment 8862144 [details]
Bug 1304508 - Remove makefile mkdir testing;

https://reviewboard.mozilla.org/r/134122/#review138070
Attachment #8862144 - Flags: review?(ted) → review+

Comment 17

9 months ago
mozreview-review
Comment on attachment 8862145 [details]
Bug 1304508 - Remove references to pymake in mozharness configs;

https://reviewboard.mozilla.org/r/134124/#review138072

We sure are good at cargo-culting things all over the place, aren't we?
Attachment #8862145 - Flags: review?(ted) → review+

Comment 18

9 months ago
mozreview-review
Comment on attachment 8862146 [details]
Bug 1304508 - Remove final references to pymake in mozharness;

https://reviewboard.mozilla.org/r/134126/#review138076
Attachment #8862146 - Flags: review?(ted) → review+

Comment 19

9 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ac37824d782c -d 3ef61ecb82e2: rebasing 392703:ac37824d782c "Bug 1304508 - Remove makefile mkdir testing; r=ted"
rebasing 392704:62bd2f5d742e "Bug 1304508 - Support passing --keep-going to make; r=chmanchester,ted"
rebasing 392705:7252984b6f94 "Bug 1304508 - Use mach for running "check" target; r=ted"
merging testing/mozharness/mozharness/mozilla/building/buildbase.py
rebasing 392706:cca94e7e75d2 "Bug 1304508 - Remove references to pymake in mozharness configs; r=ted"
other [source] changed testing/mozharness/configs/multi_locale/b2g_win32.py which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_clang.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_clang_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_clang.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_clang_debug.py
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 25

9 months ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71c2fb6144b2
Remove makefile mkdir testing; r=ted
https://hg.mozilla.org/integration/autoland/rev/26433db5f061
Support passing --keep-going to make; r=chmanchester,ted
https://hg.mozilla.org/integration/autoland/rev/4e61e69a383c
Use mach for running "check" target; r=ted
https://hg.mozilla.org/integration/autoland/rev/2fd15ad7081e
Remove references to pymake in mozharness configs; r=ted
https://hg.mozilla.org/integration/autoland/rev/b9ae5e4533dd
Remove final references to pymake in mozharness; r=ted
I see alerts showing build time improvements:
== Change summary for alert #6298 (as of May 01 2017 17:22 UTC) ==

Improvements:

 98%  build times summary linux32 pgo taskcluster-c4.4xlarge     2876.44 -> 64.25
 97%  build times summary linux64 pgo taskcluster-c4.4xlarge     2487.45 -> 64
 97%  build times summary windows2012-64 pgo taskcluster-c4.4xlarge4353.69 -> 120.32
 97%  build times summary windows2012-32 pgo taskcluster-c4.4xlarge4020.98 -> 120.62
 96%  build times summary osx-10-7 debug buildbot-unknown        4109.26 -> 175.83
 95%  build times summary linux64-stylo opt taskcluster-c4.4xlarge1252.01 -> 62.08
 95%  build times summary osx-10-7 opt buildbot-unknown          3401.66 -> 179.08
 94%  build times summary windowsxp debug buildbot-c3.4xlarge    2090.09 -> 128.7
 94%  build times summary windows8-64 opt buildbot-c3.4xlarge    2020.5 -> 125.05
 94%  build times summary windowsxp opt buildbot-c3.4xlarge      2016.45 -> 130.09
 93%  build times summary windows8-64 debug buildbot-c3.4xlarge  1998.29 -> 133.58
 93%  build times summary linux64 asan taskcluster-c4.4xlarge    1079.12 -> 78.77
 92%  build times summary linux32 debug taskcluster-c4.4xlarge   753.54 -> 63.09
 91%  build times summary windows2012-64 opt taskcluster-c4.4xlarge1335.23 -> 120.89
 91%  build times summary linux32 opt taskcluster-c4.4xlarge     684.74 -> 63.5
 91%  build times summary linux64-stylo debug taskcluster-c4.4xlarge744.54 -> 69.75
 91%  build times summary linux64 debug taskcluster-c4.4xlarge   686.08 -> 64.33
 91%  build times summary windows2012-32 opt taskcluster-c4.4xlarge1270.93 -> 120.34
 91%  build times summary linux64 opt taskcluster-c4.4xlarge     662.06 -> 62.91
 90%  build times summary windows2012-64 debug taskcluster-c4.4xlarge1205.75 -> 120.73
 90%  build times summary windows2012-32 debug taskcluster-c4.4xlarge1188.75 -> 121.13

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=6298
(Assignee)

Comment 28

9 months ago
This series broke build metrics for the "summary" reporting. I'll file a new bug.
(Assignee)

Updated

9 months ago
Blocks: 1361436
No longer blocks: 1361436
Depends on: 1361436
You need to log in before you can comment on or make changes to this bug.