1304513 - Get rid of sdk use in devtools/shared/layout/utils.js

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Brian Grinstead [:bgrins]]

Breaking this out from Bug 1291049, there's a call to memoize that we probably don't need and removing it will make bundling easier

Comment 1

[Tom Tromey :tromey]

I looked at this during track 3 and thought that shared/layout/utils wasn't needed;
but maybe that was in error?

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Tom Tromey :tromey from comment #1)
> I looked at this during track 3 and thought that shared/layout/utils wasn't
> needed;
> but maybe that was in error?

Hm maybe this change was an artifact from when we were compiling everything.  Will double check

Comment 3

[Brian Grinstead [:bgrins]]

I see a `require` here so it does end up getting compiled: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/selection.js#11.  Although it doesn't seem to throw an error anymore when running webpack.  Not sure if that's because we are somehow ignoring it, but it doesn't look like it.

Regardless, the change here is pretty trivial and it should lower our footprint / bundle size.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1304513 - Get rid of sdk use in devtools/shared/layout/utils.js;

Review commit: https://reviewboard.mozilla.org/r/80272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80272/

Comment 5

[Brian Grinstead [:bgrins]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3029245062b

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8793559 [details]
Bug 1304513 - Get rid of sdk use in devtools/shared/layout/utils.js;

https://reviewboard.mozilla.org/r/80272/#review79064

Thank you.

::: devtools/shared/layout/utils.js:7
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
>  const { Ci, Cc } = require("chrome");

This require and the uses of Ci and Cu will have to go away somehow as well...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9ff18f836877
Get rid of sdk use in devtools/shared/layout/utils.js;r=tromey

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ff18f836877