Closed
Bug 1304555
Opened 8 years ago
Closed 8 years ago
Remove Product/Channel filter from Rules history pages
Categories
(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)
Release Engineering Graveyard
Applications: Balrog (frontend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: tpingili)
References
Details
(Whiteboard: [lang=js][good first bug][ready])
Attachments
(1 file)
|
82.11 KB,
image/png
|
Details |
rule history.png
eg https://aus4-admin.mozilla.org/rules/395 and see red box on screenshot.
The 'Order by' dropdown only has the 'Data Version', and I can't think of any other dimension we could sort by.
|
Reporter | |
Updated•8 years ago
|
Summary: Rules history page should not have Product/Channel filter → Remove Product/Channel filter from Rules history pages
|
||
Updated•8 years ago
|
Whiteboard: [lang=js][good first bug]
|
|
||
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][ready]
Hi, I found these pieces of code which are related to this issue, can you please verify and let me know the right path to go ahead,
https://github.com/mozilla/balrog/blob/0be79bb7637d617fbacf79e06f5afc156e729944/ui/app/templates/rules.html#L35
https://github.com/mozilla/balrog/blob/b709987df76d5d0ed9c3789463502c653b0a734c/ui/app/js/controllers/rules_controller.js#L99
Thanks
Flags: needinfo?(bhearsum)
|
||
Comment 3•8 years ago
|
||
Hi Deepa,
You are on the right path. You can send a PR when you have made the changes.
Flags: needinfo?(bhearsum)
|
Assignee | |
Comment 4•8 years ago
|
||
Hi Ninad,
I made a PR just now.
|
||
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/bcd57207a76c7f3f6da04205675d716102096a4d
Bug 1304555:Remove Product/Channel filter from Rules history pages (#259). r=bhearsum,ninadbhat
|
|
||
Comment 6•8 years ago
|
||
In production, thank you Teja!
Assignee: nobody → tpingili
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•