Incorrect whitespace handling when middle-clicking on an "Add this term to the search form" in a crash-stats search

RESOLVED FIXED

Status

Socorro
Webapp
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: njn, Assigned: adrian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Consider this super search that is faceted on "moz crash reason":

https://crash-stats.mozilla.com/search/?product=Firefox&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-moz_crash_reason

There are a few entries where the "moz crash reason" looks like "ElementAt(aIndex = 3, aLength = 3)".

If I left-click on one of those links to perform a narrowing search, I end up at this URL:

https://crash-stats.mozilla.com/search/?moz_crash_reason=%3DElementAt%28aIndex%20%3D%203%2C%20aLength%20%3D%203%29&product=Firefox&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-moz_crash_reason

and the search works.

If I instead middle-click on one of those links I end up at a different URL:

https://crash-stats.mozilla.com/search/?moz_crash_reason=%3DElementAt%28aIndex%20&product=Firefox&page=1&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

The "moz crash reason" field has been incorrectly truncated at the first whitespace to "ElementAt(aIndex" and I get no results.
(Assignee)

Updated

a year ago
Assignee: nobody → adrian
(Assignee)

Comment 1

a year ago
Created attachment 8798312 [details] [review]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/3504

Comment 2

a year ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2b539a07ccafae7cb2344420d6de458e5832370d
Fixes bug 1304586 - Life is better when it's urlencoded. (#3504)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.