1304641 - Differential Testing: Different output message involving startTraceLogger

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

try {
    newGlobal().startTraceLogger();
    print("z");
} catch (e) {}

$ ./js-dbg-64-dm-clang-darwin-560b2c805bf7 --fuzzing-safe --no-threads --no-baseline --no-ion testcase.js

$ ./js-dbg-64-dm-clang-darwin-560b2c805bf7 --fuzzing-safe --no-threads --ion-eager testcase.js
z

Tested this on m-c rev 560b2c805bf7.

My configure flags are:

CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin14.5.0 --disable-jemalloc --enable-debug --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

python -u ~/funfuzz/js/compileShell.py -b "--enable-debug --enable-more-deterministic" -r 560b2c805bf7

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/73c94ff300b2
user:        Shu-yu Guo
date:        Wed Dec 09 07:52:58 2015 -0800
summary:     Bug 1071646 - Make functions block-scoped in JS and implement Annex B semantics for compatibility. (r=jorendorff)

Shu-yu, is bug 1071646 a likely regressor?

Comment 1

[Shu-yu Guo [:shu]]

I don't know why my patch would cause this. In TraceLoggerThread::enable, there's a compartment check for interpreter activations but no check for JIT activations. I don't know why that is. Redirecting NI.

Comment 2

[Hannes Verschore [:h4writer]]

Attachment: Patch

Always check if there is a mismatch in compartment. Not only for the interpreter.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8802110 [details] [diff] [review]
Patch

Review of attachment 8802110 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Can you add the test case please?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/671e1920ff99
TraceLogger: Also throw compartment mismatch error when running in the jits, r=bbouvier

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/671e1920ff99