1304757 - [ur] Search engine setup for Firefox for Urdu

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Francesco Lodolo [:flod]]

We want to ship Firefox with a good list of search engines for Urdu. 

We'll do this in three phases: First, the localization team and flod (Francesco Lodolo) will look at the market for the language and come up with a good set of search providers. Mohammad, we'll need your input on this. The guidelines for making recommendations are found on <https://wiki.mozilla.org/L10n:Firefox/Productization>. 

We currently use this set for en-US, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo!, Bing, Amazon, Twitter, Wikipedia

After we decided on a particular search engine, flod will contact the owner and ask for permission and for specifics, like proper search flags. Mohammad, we'll likely need your help to at least get the owner's contact information.

Once we have a specification on what the search engines for Urdu should look like, flod and the localization team will work on an implementation on that. flod will create and attach patches for the desired changes and get them reviewed. After a successful review, flod will land them. Mohammad, if you're interested, you could create the patches, too. You'd ask flod for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by flod, Stas, Axel or someone else appointed by flod. The data here is sensitive to users and our search partners, thus requiring extra care here.

The Urdu team and flod will be driving this bug to completion.

Comment 1

[Mohammed Yaseen Khan [:foxt7ot]]

Hi Flod,
my suggestion would be to go with 

>Google, Yahoo(both mobile version), Bing, Duck Duck Go, Amazon, Wikipedia, Twitter

For amazon amazon.in will work and kindly use ur.wikipedia.org

Comment 2

[Francesco Lodolo [:flod]]

Mohammed, I completely forgot: can you provide in this bug the translation in Urdu of 'Wikipedia, the Free Encyclopedia'?

It should be available under the logo here too
https://ur.wikipedia.org/wiki/خاص:تلاش

Comment 3

[Francesco Lodolo [:flod]]

@mike
Can you give me a pointer for parameters in Amazon? Looks like we don't have any amazon.in
My guess would be to use tag=firefox-in-21, based on other languages.

When ready I'll need to ask you to review the patch, given the brand new workflow.

Comment 4

[Mike Kaply [:mkaply]]

Looking at list.json, we don't use an India specific Amazon.

I don't know why that is. I'll see what I can find out.

Comment 5

[Mohammed Yaseen Khan [:foxt7ot]]

Hi Flod thanks for asking, here you go "ویکیپیڈیا آزاد دائرۃ المعارف"

Regarding amazon.in query my hunch is that we have used it previously while setting plugins for fennec.
See this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1224261 I hope that's not the different thing.

Comment 6

[Francesco Lodolo [:flod]]

Thanks for the translation.

Good point about Amazon, it's used in Fennec but it has a parameter set to 'mozilla-20', like en-US and other locales.
But it looks like on desktop they follow a different pattern. Let's see if Mike can find anything out.

Comment 7

[Mike Kaply [:mkaply]]

From Joanne:

Use local Amazon, don't worry about codes.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #7)
> Use local Amazon, don't worry about codes.
Does it mean that I can make up a code (using 'in' instead of another region), just to have a consistent structure?

Comment 9

[Mike Kaply [:mkaply]]

> Does it mean that I can make up a code (using 'in' instead of another region), just to have a consistent structure?

No, just leave out the tag line completely.

Comment 10

[Francesco Lodolo [:flod]]

Attachment: Bug 1304757 - [ur] Search engine setup for Firefox,

Review commit: https://reviewboard.mozilla.org/r/99526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99526/

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8819889 [details]
Bug 1304757 - [ur] Search engine setup for Firefox,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99526/diff/1-2/

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 8819889 [details]
Bug 1304757 - [ur] Search engine setup for Firefox,

https://reviewboard.mozilla.org/r/99526/#review102262

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d960f26e4466
[ur] Search engine setup for Firefox, r=mkaply

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d960f26e4466

Comment 15

[Francesco Lodolo [:flod]]

Moving to Firefox::Search to be able to ask for approval-aurora

Comment 16

[Francesco Lodolo [:flod]]

Comment on attachment 8819889 [details]
Bug 1304757 - [ur] Search engine setup for Firefox,

Approval Request Comment
[Feature/Bug causing the regression]: - 
[User impact if declined]: Unable to properly test Urdu Developer Edition builds.
[Is this code covered by automated tests?]: -
[Has the fix been verified in Nightly?]: No, builds are available on the aurora channel.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only impacts localized Urdu builds
[String changes made/needed]: None

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 8819889 [details]
Bug 1304757 - [ur] Search engine setup for Firefox,

search localization for urdu, aurora52+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d5fd4c474af