Intermittent devtools/client/debugger/new/test/mochitest/browser_dbg-navigation.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: intermittent-bug-filer, Assigned: bgrins)

Tracking

({intermittent-failure})

unspecified
Firefox 52
Dependency tree / graph

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed)

Details

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Priority: -- → P3
Comment hidden (Intermittent Failures Robot)
Let's go with a higher priority than that: one in a million, ASan or Win7 debug will hit this, but, on Linux32 debug it is actually permaorange.
Priority: P3 → --
Turns out permaorange was an exaggeration: I did a try run of something related, with 21 runs of this chunk, and only hit this on 20 of the 21.
Phil is right, this should be a P1.
Having said this, this should be a very simple one to fix:
- the test does pass
- it only takes a few seconds too much on Linux Debug (our slowest env)
--> So, simple fix here: increase the timeout for this test using requestLongerTimeout(2)

Eddy: can you make sure this bug gets handled by someone working on the debugger?
Flags: needinfo?(ejpbruel)
Priority: -- → P1
Assignee

Comment 10

3 years ago
We could also skip this whole folder on linux 32 debug, as we do with the current debugger tests: https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser.ini#7
Comment hidden (mozreview-request)
Assignee

Comment 12

3 years ago
What do you think?  This might also allow us to proceed with Bug 1304178. Try push:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9edede90e90704c72683099710fe81c47e6bf0b

Comment 13

3 years ago
mozreview-review
Comment on attachment 8798526 [details]
Bug 1304778 - Skip new debugger mochitests on linux 32 debug;

https://reviewboard.mozilla.org/r/83980/#review82596
Attachment #8798526 - Flags: review?(jlong) → review+

Comment 14

3 years ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/37f78aca8622
Skip new debugger mochitests on linux 32 debug;r=jlongster
Assignee

Updated

3 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee

Updated

3 years ago
Blocks: 1304178
Comment hidden (Intermittent Failures Robot)

Comment 16

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37f78aca8622
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment hidden (Intermittent Failures Robot)
Flags: needinfo?(ejpbruel)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.