Closed
Bug 1304778
Opened 8 years ago
Closed 8 years ago
Intermittent devtools/client/debugger/new/test/mochitest/browser_dbg-navigation.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Categories
(DevTools :: Debugger, defect, P1)
DevTools
Debugger
Tracking
(firefox50 unaffected, firefox51 unaffected, firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: bgrins)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment 7•8 years ago
|
||
Let's go with a higher priority than that: one in a million, ASan or Win7 debug will hit this, but, on Linux32 debug it is actually permaorange.
Priority: P3 → --
Comment 8•8 years ago
|
||
Turns out permaorange was an exaggeration: I did a try run of something related, with 21 runs of this chunk, and only hit this on 20 of the 21.
Comment 9•8 years ago
|
||
Phil is right, this should be a P1.
Having said this, this should be a very simple one to fix:
- the test does pass
- it only takes a few seconds too much on Linux Debug (our slowest env)
--> So, simple fix here: increase the timeout for this test using requestLongerTimeout(2)
Eddy: can you make sure this bug gets handled by someone working on the debugger?
Flags: needinfo?(ejpbruel)
Priority: -- → P1
Assignee | ||
Comment 10•8 years ago
|
||
We could also skip this whole folder on linux 32 debug, as we do with the current debugger tests: https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser.ini#7
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•8 years ago
|
||
What do you think? This might also allow us to proceed with Bug 1304178. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9edede90e90704c72683099710fe81c47e6bf0b
Comment 13•8 years ago
|
||
mozreview-review |
Comment on attachment 8798526 [details]
Bug 1304778 - Skip new debugger mochitests on linux 32 debug;
https://reviewboard.mozilla.org/r/83980/#review82596
Attachment #8798526 -
Flags: review?(jlong) → review+
Comment 14•8 years ago
|
||
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/37f78aca8622
Skip new debugger mochitests on linux 32 debug;r=jlongster
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (Intermittent Failures Robot) |
Comment 16•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•8 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Flags: needinfo?(ejpbruel)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•