Add a telemetry probe that measures how long it takes for a content process to start up and communicate with the parent

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM: Content Processes
P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mconley, Assigned: Benjamin Smedberg)

Tracking

50 Branch
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This would be very useful for determining if slow content process start time is related to bug 1304393.
ni'ing as requested.
Flags: needinfo?(benjamin)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Flags: needinfo?(benjamin)
Attachment #8817649 - Flags: feedback?(francois)
(Assignee)

Updated

2 years ago
Assignee: nobody → benjamin
Priority: -- → P2
Comment on attachment 8817649 [details]
Bug 1304790 - Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent,  data-r?francois

https://reviewboard.mozilla.org/r/97868/#review98214

Excited (and maybe a little worried) to see the data here. Thanks!

::: toolkit/components/telemetry/Histograms.json:196
(Diff revision 1)
> +    "expires_in_version": "57",
> +    "bug_numbers": [1304790],
> +    "kind": "exponential",
> +    "high": 64000,
> +    "n_buckets": 100,
> +    "releaseChannelCollection": "opt-out",

I guess we'll need a test for this in a follow-up bug?

::: toolkit/components/telemetry/Histograms.json:197
(Diff revision 1)
> +    "bug_numbers": [1304790],
> +    "kind": "exponential",
> +    "high": 64000,
> +    "n_buckets": 100,
> +    "releaseChannelCollection": "opt-out",
> +    "description": "Content process launch time until the GetXPCOMProcessAttributes message is received, from  in milliseconds"

Typo?: "from  in milliseconds"
Attachment #8817649 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

2 years ago
Yes, I'll add a test if this metric shows value and we decide to keep it permanently.

Comment 5

2 years ago
mozreview-review
Comment on attachment 8817649 [details]
Bug 1304790 - Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent,  data-r?francois

https://reviewboard.mozilla.org/r/97868/#review98246

This is providing user value in the form of monitoring product quality issues.

datareview+
Attachment #8817649 - Flags: review+
Attachment #8817649 - Flags: feedback?(francois)

Comment 6

2 years ago
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f00c6d7631bb
Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent, r=mconley data-r=francois

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f00c6d7631bb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Duplicate of this bug: 1307511

Comment 9

a year ago
You will be glad to look at how this telemetry probe has been doing: https://health.graphics/quantum/track?metric=CONTENT_PROCESS_LAUNCH_TIME_MS

Something landed in February which made things an order of magnitude better.
I don't think that's real. It used to measure how long it would take for the content process to start up and send its first message to the parent. Now it just measures launch time. Mike pointed this out in https://bugzilla.mozilla.org/show_bug.cgi?id=1303096#c22, but somehow that comment was never addressed (partly my fault).

We should probably base this off some other message, or maybe create a new message just for this purpose. I filed bug 1361939 for this.

Comment 11

a year ago
Thanks for the explanation, makes sense!
You need to log in before you can comment on or make changes to this bug.