13048 - spacer.gif shows up as an opaque gray rectangle in upper left of screen.

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[pnunn]

spacer.gif shows up as an opaque gray rectangle in upper left of screen.

Comment 1

[Eli Goldberg]

cc:ing cpratt, who I believe has a particular fetish for this page. ;)

Also takes place on Mac OS & Linux (1999090208 builds); changed platform to
'all'.

Comment 2

[cpratt]

yup, elig, i'm the kind of guy that would pay $3,500 for a piece of cloth with
plastic globules sewn inside of it. anyhoo: adding local (netscape-internal)
test url to the list of urls (just in case the page should change).

Comment 3

[Michael Lowe]

Attachment: Post in newsgroup

Comment 4

[pnunn]

thnx michael. I got the patch earlier
yesterday.
-pn

Comment 5

[pnunn]

Thanks for the patch.
All changes except one will be checked in.

 change1: part of bug 13048 fix.
 change2: cosmetic.
 change3: clean up, was already in the queue.
 change4: part of bug 13048 fix.
 change5: **** Wont be checked in, but thanks for
	bringing attention to it. This is an artifact
	of the old code crashing into the new component
	code.

	Take a look at new fix. The new callback
	return is of type nsresult. And multiple error
	return values aren't meaningful across the callback
	api here.
	And there was more than one occurance of this glitch.
****
	if(ic->imgdcb){
	     nsresult rv = ic->imgdcb->ImgDCBImageSize();
             if(NS_FAILED(rv)){
                 gs->state = gif_error;
		 break;
	     }
         }
         else{    //no callback is an error too.
             gs->state = gif_error;
             break;
         }
*****
 change6: part of bug 13048 fix.


These will be checked in when tree opens and/or I get
an ok from the Honchos.

Comment 6

[pnunn]

Okey doke. The patches are checked in.
Much thanks.
-pn

Comment 7

[Eli Goldberg]

Verified fixed on 1999092908 builds. Checked on Win32 [NT 4.0 SP5], Mac OS [8.6
GM], and Linux [RH 6.0/GNOME].

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b829ee3456e
[fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/13048)