1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's not obvious that the value of RELEASE_BUILD is true in release and beta builds. There is confusion and uncertainty among a share of the developers, so lets make their lives easier and rename it to RELEASE_OR_BETA.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: main patch, v1

There is also a small patch with changes the check for "release" (mean Release or Beta) in a Spidermonkey test helper function which a spidermonkey peer should review.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8793917 [details] [diff] [review]
main patch, v1

Sounds OK to me.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: main patch, v2

Feel free to redirect.

Try push is: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e97550429fec&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=28066113
Android is busted because it didn't get built with secrets.

Reasoning for change: It's not obvious that RELEASE_BUILD is also true on beta.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: spidermonkey test 'release' change, v1

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8795270 [details] [diff] [review]
spidermonkey test 'release' change, v1

This is a change to code written by you.

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8795270 [details] [diff] [review]
spidermonkey test 'release' change, v1

Review of attachment 8795270 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :D

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 8795269 [details] [diff] [review]
main patch, v2

Review of attachment 8795269 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/AppConstants.jsm
@@ +21,5 @@
>  #else
>    false,
>  #endif
>  
> +  RELEASE_OR_BETA:

I feel like you might want a Firefox peer to sign off on this, since this is available to content JS. It's possible we could break extensions if there are any using this.

I note you didn't change the `releaseBuild` property on nsIXULRuntime, so an argument could be made for keeping this as-is (although having the names in AppConstants match the names in the build system is pretty sensible).

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: xpconnect, v1

One-line-change of an at the moment unused variable.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: xulruntime's isReleaseBuild

Thank you for the review. This two-line patch changes isReleaseBuild to isReleaseOrBeta as suggested in comment 7.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8795269 [details] [diff] [review]
main patch, v2

Requesting review from Firefox peer as suggested in comment 7.

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 8795269 [details] [diff] [review]
main patch, v2

Review of attachment 8795269 [details] [diff] [review]:
-----------------------------------------------------------------

I see no extensions using that property. Ted's review is fine for the rest.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/acc5fe1c96b3
rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/aef916b9ed58
rename Spidermonkey's 'release' to 'release_or_beta'. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/a41af86326be
Rename test_xrayToJS.xul's isReleaseBuild to isReleaseOrBeta. r=gabor

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/acc5fe1c96b3
https://hg.mozilla.org/mozilla-central/rev/aef916b9ed58
https://hg.mozilla.org/mozilla-central/rev/a41af86326be

Comment 14

[(not currently active) Ted Mielczarek]

Comment on attachment 8797609 [details] [diff] [review]
xulruntime's isReleaseBuild

Review of attachment 8797609 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, this isn't used anywhere in the tree? Interesting!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2451168a497
Rename nsXULAppInfo's isReleaseBuild to isReleaseOrBeta. r=ted

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f2451168a497