Closed Bug 1304865 Opened 6 years ago Closed 6 years ago

Fix uses of engine._itemSource in TPS and collection validator.

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Bug 1304865 - Replace remaining uses of _itemSource with itemSource in sync and tps
58 bytes, text/x-review-board-request
markh
: review+
Details 
This function got renamed in the patch that enabled telemetry validation, but since these were added since that patch was initially authored, they missed it.

They only fire when TPS is run, or in a method that's not currently called in the collection_validator.

Patch incoming.
Comment on attachment 8793931 [details]
Bug 1304865 - Replace remaining uses of _itemSource with itemSource in sync and tps

https://reviewboard.mozilla.org/r/80530/#review79308
Attachment #8793931 - Flags: review?(markh) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a18668c1ff8d
Replace remaining uses of _itemSource with itemSource in sync and tps. r=markh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a18668c1ff8d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.