1304869 - Windows fails to configure with custom CFLAGS: memory\jemalloc\src> configure: error: Cannot build without ffsl(3) or __builtin_ffsl()

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Custom CFLAGS worked before bug 1262155 landed.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Alternatively, custom CFLAGS support should explicitly be deprecated and removed.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1304869 - Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig.

A side effect of ffi.m4 was that it would un-set CFLAGS when compiling with MSC.
This incidentally worked around the fact that if CFLAGS are set in jemalloc's
configure, it will not set certain variables that are necessary to configure
jemalloc, but are unlikely to be set manually by someone building Firefox.

Review commit: https://reviewboard.mozilla.org/r/80548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80548/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8793980 [details]
Bug 1304869 - Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig.

https://reviewboard.mozilla.org/r/80548/#review79900

::: build/autoconf/jemalloc.m4:75
(Diff revision 1)
>      fi
>      unset CONFIG_FILES
>      if test -z "$MOZ_TLS"; then
>        ac_configure_args="$ac_configure_args --disable-tls"
>      fi
>      EXTRA_CFLAGS="$CFLAGS"

This line puts our non-reset-by-ffi.m4 CFLAGS into EXTRA_FLAGS, that is appended to CFLAGS in jemalloc's configure. Doesn't that break configure the same way?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8793980 [details]
Bug 1304869 - Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig.

https://reviewboard.mozilla.org/r/80548/#review79900

> This line puts our non-reset-by-ffi.m4 CFLAGS into EXTRA_FLAGS, that is appended to CFLAGS in jemalloc's configure. Doesn't that break configure the same way?

Aha, no. The issue isn't that we have CFLAGS set that are incompatible with jemalloc's configure, the issue is that jemalloc's configure neglects to set some (necessary) things if it sees the CFLAGS _variable_ has been set at all, as described here: http://searchfox.org/mozilla-central/rev/767e1e9b118269f957ca1817138472146278a29e/memory/jemalloc/src/configure.ac#117

It looks like the relavant thing that ends up missing is the line `CPPFLAGS="$CPPFLAGS -I${srcdir}/include/msvc_compat"` a bit further down.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8793980 [details]
Bug 1304869 - Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig.

Re-requesting review based on comment 4 so this discussion doesn't get lost along the way.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8793980 [details]
Bug 1304869 - Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig.

https://reviewboard.mozilla.org/r/80548/#review81536

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3166f22eca26
Unset CFLAGS when invoking jemalloc's configure to accomodate setting CFLAGS in mozconfig. r=glandium

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3166f22eca26