1304881 - Can't create a Custom recurring Monthly event

Status: RESOLVED FIXED

Description

[WaltS48 [:walts48]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160920155715

Steps to reproduce:

Created an event for the first Tuesday of the month (Oct)
Set the Start and End times
Selected Custom... for Repeat
Selected Monthly for the Recurrence pattern
Selected The First Tuesday
Selected Create 5 Appointments for Range of recurrence
Clicked OK



Actual results:

The Preview showed the event occurring on the 1st Tuesday in October and the 4th of every following month, not the 1st Tuesday of the following months
Nothing happened when I clicked OK


Expected results:

The Preview should have showed the event recurring every 1st Tuesday of the following months
Clicking OK should have closed the Edit Recurrence dialog box allowing me to Save and Close the Event.

Comment 1

[Decathlon]

Attachment: patch - v1

Confirmed.
A message "TypeError: aElement is null" appears in the console.

There is a typo in the file calendar-event-dialog-recurrence.js.
Regression from bug 1280898.

Comment 2

[[:MakeMyDay]]

Comment on attachment 8794099 [details] [diff] [review]
patch - v1

Review of attachment 8794099 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick patch, r=me

Comment 3

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 8794099 [details] [diff] [review]
patch - v1

Blanket a=me for eslint regressions as they all need to go to aurora anyway.

Comment 4

[:aceman]

https://hg.mozilla.org/comm-central/rev/af97c06e4a9465b2292a7f69c8006ba8261fbc05

Comment 5

[Patrick Cloke [:clokep]]

Uplifted: https://hg.mozilla.org/releases/comm-aurora/rev/f3784bf19b49