130491 - Make buttons disabled while form submission occurs

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[John Keiser (jkeiser)]

We need to give a visual and tactile indication when the user is unable to
submit a form because another form submission is currently occurring.  Now that
bug 72906 is checked in, this is a must-have.

Comment 1

[John Keiser (jkeiser)]

So what I'm thinking we do here is, disable the buttons after we have built the
request and sent it off.  We *cannot* disable the buttons before that, because
the buttons may be used in building the request.  We should disable all <input
type=submit> and <button type=submit>s.  Unfortunately in the case of JS submit
we will not be giving a visual indication of what is happening, but that cannot
be helped.

One big annoying problem here is, we need to keep a list of the buttons we
disabled.  If JS disabled a button before, we don't want to un-disable it after
we finish.

A second possibility here is to set a :_moz-submitting selector on the form. 
the more I think about that the more I like it.  We wouldn't have to add
anything at all to the form.  We could style <input type=submit> and <button
type=submit> as greyed out when they are inside a form with :_moz-submitting. 
The only drawback is, the buttons would still depress and onClick handlers on
these elements would still run, though submission and onSubmit() still would
not.  Is that acceptable?

Comment 2

[m_mozilla]

...and be sure to handle the case where the server returns status 204 or the
like. In that case, the current page still needs to be displayed, and the
buttons need to be reenabled once the status 204 is returned.

-matt

Comment 3

[John Keiser (jkeiser)]

Yes, that is handled already.  At this point all we should have to deal with is
the visual component.

Comment 4

[Kevin McCluskey (gone)]

Bulk moving P1-P5 un-milestoned bugs to future. 

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I am going to close this as INCOMPLETE. https://bugzilla.mozilla.org/show_bug.cgi?id=1803805 has more context for the related and broader issue, especially after a lot of code changes after fission. If you don't think bug 1803805 cover the scope you have on mind, please feel free to open a new issue.