Closed Bug 1304920 Opened 4 years ago Closed 4 years ago

Non ICE binding requests include fingerprint

Categories

(Core :: WebRTC: Networking, defect, P3)

52 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

The binding request from Firefox STUN server to query for server reflexive candidates contains the fingerprint attribute.

RFC 5389 says the fingerprint is added to allow implementations which multiplex multiple protocols on the same port to differentiate the protocols. That is clearly not the case when querying your public IP and port. RFC 5389 says:
"Since the stand-alone server only runs STUN, FINGERPRINT provides no benefit."
backlog: --- → webrtc/webaudio+
Rank: 35
Comment on attachment 8794018 [details]
Bug 1304920: remove fingerprint attribute from plain binding requests.

https://reviewboard.mozilla.org/r/80580/#review79380

::: media/mtransport/third_party/nICEr/src/stun/stun_build.h:43
(Diff revision 1)
>  
>  #define NR_STUN_MODE_STUN               1
>  #ifdef USE_STUND_0_96
>  #define NR_STUN_MODE_STUND_0_96         2    /* backwards compatibility mode */
>  #endif /* USE_STUND_0_96 */
> +#define NR_STUN_MODE_STUN_NO_ATTR       3

NO_AUTH?
Comment on attachment 8794018 [details]
Bug 1304920: remove fingerprint attribute from plain binding requests.

https://reviewboard.mozilla.org/r/80580/#review79382

gtest looks sad, I'm guessing our server code insists on there being a fingerprint?
Attachment #8794018 - Flags: review?(docfaraday)
(In reply to Byron Campen [:bwc] from comment #3)
> gtest looks sad, I'm guessing our server code insists on there being a
> fingerprint?

I think that is an actual bug in our STUN TCP implementation. Let me know if I should submit that in a separate bug report for better tracking.
Comment on attachment 8794018 [details]
Bug 1304920: remove fingerprint attribute from plain binding requests.

https://reviewboard.mozilla.org/r/80580/#review79688
Attachment #8794018 - Flags: review?(docfaraday) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/5abb97190394
remove fingerprint attribute from plain binding requests. r=bwc
https://hg.mozilla.org/mozilla-central/rev/5abb97190394
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.