1305201 - Change BasePoint::Length() to return Coord

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Botond Ballo [:botond] from bug 1298886 comment 7:
>
> Can we change BasePoint::Length() to return Coord, while we're at it?
> 
> (I originally didn't do that for the reason mentioned in bug 1055741 comment
> 11, but I've since been convinced otherwise (bug 1055741 comment 12)).

Comment 1

[Botond Ballo [:botond]]

We could also make this a mentored bug, if you'd like.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I'm happy to just fix it. I had kicked off a local build with the one-line change anyway, and that seems to be all there is to it. Try push to confirm:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2482f972a8f6

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1305201 - Have BasePoint::Length return a Coord instead of a raw type.

Review commit: https://reviewboard.mozilla.org/r/81170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81170/

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8794975 [details]
Bug 1305201 - Have BasePoint::Length return a Coord instead of a raw type.

https://reviewboard.mozilla.org/r/81170/#review79774

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b7bf04ea347
Have BasePoint::Length return a Coord instead of a raw type. r=botond

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b7bf04ea347

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdb051f7a44f
Follow-up to fix some debug logging. r=me and DONTBUILD because NPOTB

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bdb051f7a44f