Closed Bug 1305201 Opened 4 years ago Closed 4 years ago

Change BasePoint::Length() to return Coord

Categories

(Core :: Graphics, defect)

52 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Botond Ballo [:botond] from bug 1298886 comment 7:
>
> Can we change BasePoint::Length() to return Coord, while we're at it?
> 
> (I originally didn't do that for the reason mentioned in bug 1055741 comment
> 11, but I've since been convinced otherwise (bug 1055741 comment 12)).
We could also make this a mentored bug, if you'd like.
I'm happy to just fix it. I had kicked off a local build with the one-line change anyway, and that seems to be all there is to it. Try push to confirm:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2482f972a8f6
Comment on attachment 8794975 [details]
Bug 1305201 - Have BasePoint::Length return a Coord instead of a raw type.

https://reviewboard.mozilla.org/r/81170/#review79774
Attachment #8794975 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b7bf04ea347
Have BasePoint::Length return a Coord instead of a raw type. r=botond
https://hg.mozilla.org/mozilla-central/rev/0b7bf04ea347
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdb051f7a44f
Follow-up to fix some debug logging. r=me and DONTBUILD because NPOTB
You need to log in before you can comment on or make changes to this bug.