Closed
Bug 1305259
Opened 8 years ago
Closed 8 years ago
Support subpixel AA in CSS mask / clip-path
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(2 files, 1 obsolete file)
This will be useful for bug 658467, and the patch is really simple.
| Comment hidden (mozreview-request) |
Comment on attachment 8794546 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.
https://reviewboard.mozilla.org/r/80964/#review79592
LGTM
(Maybe it's a good idea to run through Talos cart)
Attachment #8794546 -
Flags: review?(cku) → review+
|
||
Comment 3•8 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #0)
> Created attachment 8794545 [details]
> testcase
>
> This will be useful for bug 658467, and the patch is really simple.
This indeed involved a significant performance hit. Be sure to quantify that.
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8794546 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.
https://reviewboard.mozilla.org/r/80964/#review79616
Attachment #8794546 -
Flags: review?(bas) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8794546 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•8 years ago
|
||
Uh, not sure why mozreview decided to re-request review. Anyway, I've added a check so that we only do this if there's actually text over transparent background inside the mask / clip-path, so that we don't pay the cost when it's not necessary.
|
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8796776 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.
https://reviewboard.mozilla.org/r/82516/#review81168
Attachment #8796776 -
Flags: review?(bas) → review+
Comment on attachment 8796776 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.
https://reviewboard.mozilla.org/r/82516/#review81332
Attachment #8796776 -
Flags: review?(cku) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/265f9ccf4fff
Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path. r=cjku, r=Bas
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•