1305282 - Pressing "space" key when focus is in a select menu open it instead of going to the first option which have a space

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[info]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

I have a website with select menus which have pretty long list of options (around 1k). Since the dawn of Firefox (well, at least for the 5-6 latest years), I was used to select the html select menu and type text to go to the first option that match my text (without opening the select menu to see the options, or at least some of them). 


Actual results:

After installing the version 49.0.1 yesterday (saturday 24 september), this does not work anymore when text does contains spaces. When I press the "space" key (independently if the space is typed as first character or not), Firefox does open the option list instead of selecting the first option that have a space at this point of the typed text.


Expected results:

When pressing the space key in a select menu which is not opened, firefox should select the first option that match the space rather than opening the option list (as it was for the last 5-6 years).

Please note that a workaround exists : if I open first the option list, then type my text, this works as expected. But it is an additional step when moving with the "tab" key from select menu to select menu (example : tab -> space -> type text -> tab -> space -> type text -> ... instead of doing only tab -> type text -> tab -> type text).

If this can be reverted, would be great.
Note that I launched Edge to compare, it does behave like Firefox previous versions (< 49). I do not have Chrome installed at home, cannot say how it does behave.

Comment 1

[Loic]

Could you provide the URL of the website or a reduced testcase, please.

Comment 2

[info]

https://www.final-fantasy.ch/temp/1305282.html

Load this page, the focus is automatically placed on the first select list (piece of JS). Type this exact text (whithout the quotes) : "le la".

Expected : focus is placed on the 9-th element of the list named "Le Labyrinthe des illusions".
Actual : after typing "le", focus is quickly placed on the 9-th element, then "space" key does open the select list, then "la" places the focus on "L'épreuve du sage", which is the first element starting by "l" as there is no element in the whole list starting by "la".

Comment 3

[Justin [:JW_SoftvisionQA]]

I can not reproduce this issue on User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

Following the steps above I get the expected results 10-10 times.

Comment 4

[Loic]

I can reproduce it.

Reg range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8d0aadfe7da782d415363880008b4ca027686137&tochange=56e5195bef5bf352d37181195dc6043ac3d198ad

Mats Palmgren — Bug 1272012 - Support more keys to open and/or toggle a combobox dropdown menu. r=enndeakin

Comment 5

[Mats Palmgren (inactive)]

Oops, sorry, this is definitely an unintentional side effect of that change.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix in 49 but we could still consider a patch for 50. There is a workaround, at least.

Comment 7

[Mats Palmgren (inactive)]

Attachment: fix

Comment 8

[Mats Palmgren (inactive)]

Attachment: mochitest

Comment 9

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e904cd0081e8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c504ea22e0f6ebdbe8049084acdf1c2c6b6d2c48

Comment 10

[Marcia Knous [:marcia]]

Tracking 52+ for this regression.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9a39c2222d
Make the SPACE key work for incremental search of options again.  r=enndeakin
https://hg.mozilla.org/integration/mozilla-inbound/rev/883ba9064d88
Test using the SPACE key in incremental search of options.

Comment 12

[Mats Palmgren (inactive)]

Comment on attachment 8796774 [details] [diff] [review]
fix

Approval Request Comment
[Feature/regressing bug #]:bug 1272012 
[User impact if declined]: minor usability issue with <select> lists
[Describe test coverage new/current, TreeHerder]: comes with a mochitest
[Risks and why]: low-risk
[String/UUID change made/needed]: none

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e9a39c2222d
https://hg.mozilla.org/mozilla-central/rev/883ba9064d88

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8796774 [details] [diff] [review]
fix

Fixes a recent regression, Aurora51+, Beta50+

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d98a2c44e2f7
https://hg.mozilla.org/releases/mozilla-aurora/rev/7a8489d5e1e7

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4f4a7d3bf772
https://hg.mozilla.org/releases/mozilla-beta/rev/d567c7677412

Comment 17

[info]

Confirmed fixed, received the 50.0 version today.

Comment 18

[Rainer Bielefeld]

To be honest, I haven't a clue what might have been fixed here.

If I understand reporter correctly he expcts
1. Open this web page in Browser → log in
2. click into "Whiteboard" input line
   » caret appears
3. click <TAB> several times until "Version" Dropdown is selected
   » Selection border appears around several fields until it reaches 
     "Version" Dropdown 
4. Type "49"
   » Dropdown contents switches to a result containing "49"

Sample from Comment 2 ist not very useful, this long list contains more or less any  string you can type ...

But With FF 54.0a1 (2017-02-01) (32-bit) for me the result in Step 4 always immediately shows the field Starting with the last typed character:
Having typed "4" I see "40 Branch"
Having typed "9" I see "9 Branch"

Do I misunderstand something?
Is there a particular preference I need (find as you type, whatever, ... )?

Comment 19

[Rainer Bielefeld]

oops

Comment 20

[Neil Deakin]

When a <select> is focused but not opened, typing characters including with spaces in them should autcomplete to options in the list, but not open the dropdown. The bug here was that space opened the dropdown always, but should only do so when there is no match or the typing timeout expires.

Bug 1338246 was filed against 49 so is certainly a duplicate, even though it is a Seamonkey bug.