1305336 - Intermittent dom/media/test/test_streams_autoplay.html | TypeError: v.mozDumpDebugInfo is not a function

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

test_streams_autoplay.html doesn't use MediaTestManager. We need to set the pref ["media.test.dumpDebugInfo", true] manually.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305336. Part 1 - extract some code to a function.

Review commit: https://reviewboard.mozilla.org/r/81028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81028/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305336. Part 2 - use 'once' handler to remove onPlayingEventFired.

Review commit: https://reviewboard.mozilla.org/r/81030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81030/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305336. Part 3 - set prefs before running tests.

Review commit: https://reviewboard.mozilla.org/r/81032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81032/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305336. Part 4 - create elements dynamically because pref changes only take effect for those elements that are created later.

Review commit: https://reviewboard.mozilla.org/r/81034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81034/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305336. Part 5 - use manifestVideo() so pref changes can take effect as expected.

Review commit: https://reviewboard.mozilla.org/r/81036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81036/

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8794703 [details]
Bug 1305336. Part 1 - extract some code to a function.

https://reviewboard.mozilla.org/r/81028/#review79662

Not sure I like the startTest definition indented like that, but it does help with reading.

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8794704 [details]
Bug 1305336. Part 2 - use 'once' handler to remove onPlayingEventFired.

https://reviewboard.mozilla.org/r/81030/#review79664

Comment 8

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8794705 [details]
Bug 1305336. Part 3 - set prefs before running tests.

https://reviewboard.mozilla.org/r/81032/#review79666

Comment 9

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8794706 [details]
Bug 1305336. Part 4 - create elements dynamically because pref changes only take effect for those elements that are created later.

https://reviewboard.mozilla.org/r/81034/#review79668

::: dom/media/test/test_streams_autoplay.html:24
(Diff revision 1)
>  } else {
>    function startTest() {
> -    v1.src = media.name;
> +    var v1 = document.createElement('video');
> +    var v2 = document.createElement('video');
>      v1.preload = 'metadata';
> +    v2.autoplay = true;

This should use `v2.setAttribute` to be equivalent to the old code. Though we never change the source so it shouldn't matter.

Comment 10

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8794707 [details]
Bug 1305336. Part 5 - use manifestVideo() so pref changes can take effect as expected.

https://reviewboard.mozilla.org/r/81036/#review79670

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77f19f37b30c
Part 1 - extract some code to a function. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/f4e6468a9856
Part 2 - use 'once' handler to remove onPlayingEventFired. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/6eaeadf49020
Part 3 - set prefs before running tests. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/bbb609d92b20
Part 4 - create elements dynamically because pref changes only take effect for those elements that are created later. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/719b68f344f5
Part 5 - use manifestVideo() so pref changes can take effect as expected. r=pehrsons

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77f19f37b30c
https://hg.mozilla.org/mozilla-central/rev/f4e6468a9856
https://hg.mozilla.org/mozilla-central/rev/6eaeadf49020
https://hg.mozilla.org/mozilla-central/rev/bbb609d92b20
https://hg.mozilla.org/mozilla-central/rev/719b68f344f5