Closed Bug 1305385 Opened 5 years ago Closed 5 years ago

Remove section about Edit button from Peoples tab and Server tab in the Certificate Manager

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.49

People

(Reporter: nONoNonO, Assigned: nONoNonO)

References

Details

Attachments

(1 file, 1 obsolete file)

While localizing certs_help.xhtml I came across the help for the Edit button on the Peoples tab, which I couldn't find in the UI. It seems that this functionality was removed in bug 1130418, but the corresponding help text was never updated.
Summary: Remove section about Edit button from Peoples tab in the Certificate Manager → Remove section about Edit button from Peoples tab and Server tab in the Certificate Manager
In bug 825583 the Edit functionality was also removed from the Server tab…
Assignee: nobody → o.e.ekker
Status: NEW → ASSIGNED
Comment on attachment 8795252 [details] [diff] [review]
Remove Edit sections from certs_help.xhtml

Thanks for the patch. Note that you should always fill in the requestee field when you set the review flag to "?". Then the requestee will get an email (having a blank requestee field is risky, your request might not get any attention).

Anyway, I've looked at your patch and it looks good :-)

One thing, though: The "Import" button in the Servers tab doesn't seem to exist anymore, so please remove that from the help file as well.

If you put up a new patch with that change, I'll r+ it
Attachment #8795252 - Flags: review?
(In reply to Stefan [:stefanh] from comment #3) 
> If you put up a new patch with that change, I'll r+ it

If you ask me for review, of course ;-)
Blocks: 1130418, 825583
Attached patch Patch v2Splinter Review
I did see two other nits: in bug 173729 the Edit and Delete buttons on the Authorities tab were renamed to Edit Trust and Delete or Distrust. I think it suffices to only change the button's labels and that the text itself doesn't need to change…
Attachment #8795252 - Attachment is obsolete: true
Attachment #8796008 - Flags: review?(stefanh)
Blocks: 173729, 1064402
Comment on attachment 8796008 [details] [diff] [review]
Patch v2

Thanks!
Attachment #8796008 - Flags: review?(stefanh) → review+
https://hg.mozilla.org/comm-central/rev/9569b194aa19
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
You need to log in before you can comment on or make changes to this bug.