Remove section about Edit button from Peoples tab and Server tab in the Certificate Manager

RESOLVED FIXED in seamonkey2.49

Status

defect
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nONoNonO, Assigned: nONoNonO)

Tracking

unspecified
seamonkey2.49
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

3 years ago
While localizing certs_help.xhtml I came across the help for the Edit button on the Peoples tab, which I couldn't find in the UI. It seems that this functionality was removed in bug 1130418, but the corresponding help text was never updated.
Assignee

Updated

3 years ago
Summary: Remove section about Edit button from Peoples tab in the Certificate Manager → Remove section about Edit button from Peoples tab and Server tab in the Certificate Manager
Assignee

Comment 1

3 years ago
In bug 825583 the Edit functionality was also removed from the Server tab…

Updated

3 years ago
Assignee: nobody → o.e.ekker
Status: NEW → ASSIGNED

Comment 3

3 years ago
Comment on attachment 8795252 [details] [diff] [review]
Remove Edit sections from certs_help.xhtml

Thanks for the patch. Note that you should always fill in the requestee field when you set the review flag to "?". Then the requestee will get an email (having a blank requestee field is risky, your request might not get any attention).

Anyway, I've looked at your patch and it looks good :-)

One thing, though: The "Import" button in the Servers tab doesn't seem to exist anymore, so please remove that from the help file as well.

If you put up a new patch with that change, I'll r+ it
Attachment #8795252 - Flags: review?

Comment 4

3 years ago
(In reply to Stefan [:stefanh] from comment #3) 
> If you put up a new patch with that change, I'll r+ it

If you ask me for review, of course ;-)

Updated

3 years ago
Blocks: 1130418, 825583
Assignee

Comment 5

3 years ago
Posted patch Patch v2Splinter Review
I did see two other nits: in bug 173729 the Edit and Delete buttons on the Authorities tab were renamed to Edit Trust and Delete or Distrust. I think it suffices to only change the button's labels and that the text itself doesn't need to change…
Attachment #8795252 - Attachment is obsolete: true
Attachment #8796008 - Flags: review?(stefanh)
Assignee

Updated

3 years ago
Blocks: 173729, 1064402

Comment 6

3 years ago
Comment on attachment 8796008 [details] [diff] [review]
Patch v2

Thanks!
Attachment #8796008 - Flags: review?(stefanh) → review+

Comment 7

3 years ago
https://hg.mozilla.org/comm-central/rev/9569b194aa19
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
You need to log in before you can comment on or make changes to this bug.