1305420 - In some iframes, modal highlight doesn't work correctly

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[roxleitan]

Attachment: iframe.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

[Affected versions]:
Nightly 52.0a1

[Affected platforms]:
Windows 10 x 64 , Ubuntu 15.04

[Steps to reproduce]:
1.Launch Nightly 52.0a1 with a new profile
2.Open http://claws-mail.org/documentation.php?section=general
3.Open Find Bar (Ctrl+F)
4.Search for "pass"

[Expected result]:
All the matching terms should be found. The first one should have a yellow background highlighted, and the other ones a white background.

[Actual result]:
Highlight makes the first matching term invisible and the other ones are visible but not highlighted.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1305420 - don't include the topmost windows' scroll-position for iframes, or else it will be counted twice.

Review commit: https://reviewboard.mozilla.org/r/81388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81388/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8795271 [details]
Bug 1305420 - don't include the topmost windows' scroll-position for iframes, or else it will be counted twice.

https://reviewboard.mozilla.org/r/81388/#review80394

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f36d1ab003c8
don't include the topmost windows' scroll-position for iframes, or else it will be counted twice. r=jaws

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f36d1ab003c8

Comment 5

[Ciprian Georgiu, Desktop QA]

Reproduced this issue on Nightly 52.0a1 (2016-09-26) with STR from Roxana's comment 0.

This bug is verified fixed on latest Nightly 52.0a1 (2016-09-29) under following OSes:
- Windows 10 x64
- Ubuntu 16.04 x64 LTS
- macOS 10.12.1