Closed Bug 1305457 Opened 8 years ago Closed 8 years ago

product and component quick search does not work from describecomponents.cgi gives error if not logged in

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

Details

Attachments

(1 file)

API error message is: "The token is not valid. It could be because you loaded this page more than 3 days ago." We should not be passing a token if user is not logged in.

dkl
Attached patch 1305457_1.patchSplinter Review
Current code passes Bugzilla_api_token as empty key/value. Auth/Login/Cookie.pm checks if Bugzilla_api_token key exists and if so tries to verify it even if empty. If not verified then throws error. We do not pass at all if user is not logged in. The API still hides private products for non-logged in users so no problems there.

dkl
Attachment #8794922 - Flags: review?(dylan)
Comment on attachment 8794922 [details] [diff] [review]
1305457_1.patch

r=dylan
Attachment #8794922 - Flags: review?(dylan) → review+
To https://github.com/mozilla-bteam/bmo.git
   e21bf08..82c9e29  master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Extensions: ProdCompSearch → Extensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: