Use 0-1 min as the initial update delay for both V2 and V4

RESOLVED FIXED in Firefox 52

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hchang, Assigned: hchang)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: #sbv4-m1)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Safe Browsing V2 and V4 uses different initial update delay: v2 is 0~5 and v4 is 0~1. We wonder if we can use the same initial delay for both v2 and v4.
(Assignee)

Updated

2 years ago
Whiteboard: #sbv4-m1
I will check with Google to see if we can always do 0-1 minutes.
Assignee: nobody → francois
Status: NEW → ASSIGNED
Priority: -- → P2
(In reply to François Marier [:francois] from comment #1)
> I will check with Google to see if we can always do 0-1 minutes.

Google is fine with our simplifying our code and using 0-1 minutes for both V2 and V4.
Assignee: francois → nobody
Blocks: 1167038
Status: ASSIGNED → NEW
Summary: Use same initial update delay for v2 and v4 → Use 0-1 min as the initial update delay for both V2 and V4
(Assignee)

Updated

2 years ago
Assignee: nobody → hchang
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8799625 - Flags: review?(francois)
(Assignee)

Comment 5

2 years ago
There is a 3000ms minimum initial update delay since the very beginning [1]. No idea if we should remove this empirical bound.

[1] https://hg.mozilla.org/mozilla-central/annotate/0521f176e739/toolkit/components/url-classifier/content/listmanager.js#l219
(In reply to Henry Chang [:henry][:hchang] from comment #5)
> There is a 3000ms minimum initial update delay since the very beginning [1].
> No idea if we should remove this empirical bound.

I'm fine with this extra 3 seconds. It seems like a good idea to avoid doing anything in the first 3 seconds of startup. There is already a lot of I/O at this point.

Comment 7

2 years ago
mozreview-review
Comment on attachment 8799625 [details]
Bug 1305478 - Unify the initial update delay (for both v2 and v4) to 0~1 minute.

https://reviewboard.mozilla.org/r/84766/#review83944
Attachment #8799625 - Flags: review?(francois) → review+

Comment 8

2 years ago
Pushed by hchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5dc333cf5a57
Unify the initial update delay (for both v2 and v4) to 0~1 minute. r=francois

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5dc333cf5a57
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.