Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame

RESOLVED WONTFIX

Status

()

Core
Layout
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
After we fix both Bug 1304991 and Bug 1305636, there is no need to pass opacity to nsSVGMaskFrame::GetMaskForMaskedFrame. We can remove this parameter from nsSVGMaskFrame::GetMaskForMaskedFrame, ComputeLinearRGBLuminanceMask, ComputeAlphaMask, ComputesRGBLuminanceMask.
(Assignee)

Updated

2 years ago
Depends on: 1304991, 1305636
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8795263 - Flags: review?(mstange)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8795263 [details]
Bug 1305637 - Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame.

https://reviewboard.mozilla.org/r/81380/#review80014

::: layout/svg/nsSVGMaskFrame.cpp:112
(Diff revision 2)
> -  int32_t redFactor = 55 * aOpacity; // 255 * 0.2125 * opacity
> -  int32_t greenFactor = 183 * aOpacity; // 255 * 0.7154 * opacity
> +  int32_t redFactor = 55; // 255 * 0.2125 * opacity
> +  int32_t greenFactor = 183; // 255 * 0.7154 * opacity

Please remove " * opacity" from the comments.
Attachment #8795263 - Flags: review?(mstange) → review+
(Assignee)

Comment 6

2 years ago
Base on bug 1305636 comment 7, we don't need the patch here. Close it.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 years ago
No longer depends on: 1305636
You need to log in before you can comment on or make changes to this bug.