1305637 - Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[u459114]

After we fix both Bug 1304991 and Bug 1305636, there is no need to pass opacity to nsSVGMaskFrame::GetMaskForMaskedFrame. We can remove this parameter from nsSVGMaskFrame::GetMaskForMaskedFrame, ComputeLinearRGBLuminanceMask, ComputeAlphaMask, ComputesRGBLuminanceMask.

Comment 1

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ca40aeba188

Comment 2

[u459114]

Attachment: Bug 1305637 - Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame.

Review commit: https://reviewboard.mozilla.org/r/81380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81380/

Comment 3

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41e738323f6e

Comment 4

[u459114]

Comment on attachment 8795263 [details]
Bug 1305637 - Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81380/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8795263 [details]
Bug 1305637 - Remove aOpacity function parameter of nsSVGMaskFrame::GetMaskForMaskedFrame.

https://reviewboard.mozilla.org/r/81380/#review80014

::: layout/svg/nsSVGMaskFrame.cpp:112
(Diff revision 2)
> -  int32_t redFactor = 55 * aOpacity; // 255 * 0.2125 * opacity
> -  int32_t greenFactor = 183 * aOpacity; // 255 * 0.7154 * opacity
> +  int32_t redFactor = 55; // 255 * 0.2125 * opacity
> +  int32_t greenFactor = 183; // 255 * 0.7154 * opacity

Please remove " * opacity" from the comments.

Comment 6

[u459114]

Base on bug 1305636 comment 7, we don't need the patch here. Close it.