../../../dist/include/GrallocImages.h:96:43: error: 'GetTextureClient' declared as a 'virtual' field

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 7 obsolete attachments)

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7ead4d4eb90ac9e8f112574dc194691e507658e
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b7ead4d4eb90&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=36497577


../../../dist/include/GrallocImages.h:96:43: error: 'GetTextureClient' declared as a 'virtual' field
../../../dist/include/GrallocImages.h:96:26: error: expected ';' at end of member declaration
../../../dist/include/GrallocImages.h:96:59: error: expected ')' before '*' token
../../../dist/include/mozilla/layers/GrallocTextureClient.h:77:3: error: 'virtual mozilla::layers::TextureData* mozilla::layers::GrallocTextureData::CreateSimilar(mozilla::layers::LayersIPCChannel*, mozilla::layers::TextureFlags, mozilla::layers::TextureAllocationFlags) const' marked override, but does not override
../../../dist/include/mozilla/layers/TextureClient.h:281:3: error: 'virtual mozilla::layers::TextureData* mozilla::layers::TextureData::CreateSimilar(mozilla::layers::LayersIPCChannel*, mozilla::layers::LayersBackend, mozilla::layers::TextureFlags, mozilla::layers::TextureAllocationFlags) const' was hidden [-Werror=overloaded-virtual]
../../../dist/include/mozilla/layers/GrallocTextureClient.h:77:3: error: by 'virtual mozilla::layers::TextureData* mozilla::layers::GrallocTextureData::CreateSimilar(mozilla::layers::LayersIPCChannel*, mozilla::layers::TextureFlags, mozilla::layers::TextureAllocationFlags) const' [-Werror=overloaded-virtual]
make[6]: *** [Unified_cpp_dom_media_webrtc0.o] Error 1
Attachment #8795279 - Flags: review?(nical.bugzilla) → review+
Assignee: nobody → lissyx+mozillians
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43a97503d564
Decouple Gonk TextureForwarder and CompositableForwarder (followup bug 1281456) r=nical
https://hg.mozilla.org/mozilla-central/rev/43a97503d564
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.