Closed Bug 1305698 Opened 3 years ago Closed 3 years ago

"Some add-ons have been disabled" paragraph is misaligned

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox50 --- verified
firefox51 --- verified
firefox52 --- verified

People

(Reporter: vasilica.mihasca, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Affected versions]:
Firefox 52.0a1 (2016-09-26)
Firefox 51.0a2 (2016-09-26)
Firefox 50.0b2 (20160926162149)

[Affected platforms]:
Windows 10 64-bit  
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Navigate to about:config and set xpinstall.signatures.required to false. 
3.Install an unsigned add-on.
4.Toggle back the xpinstall.signatures.required to true.
5.Navigate to about:addons and click on “Some extensions could not be verified” button.


[Expected results]:
The paragraph is properly aligned.


[Actual results]:
There is no left padding: http://screencast.com/t/K5xX0Mrn


[Regression range]:
Last good revision: 5f95858f8ddf21ea2271a12810332efd09eff138
First bad revision: 530e96008b7e987c75ddbab59cabdc11f9bbabb9
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5f95858f8ddf21ea2271a12810332efd09eff138&tochange=530e96008b7e987c75ddbab59cabdc11f9bbabb9

I suspect that this issue was regressed by Bug 1273974
Attached patch Bug1305698.patchSplinter Review
Sorry, I missed this one.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #8795417 - Flags: review?(gijskruitbosch+bugs)
Attachment #8795417 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fba3876cab0
Add a margin of 48px to #disabled-unsigned-addons-info in Add-on manager. r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9fba3876cab0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795417 [details] [diff] [review]
Bug1305698.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1273974
[User impact if declined]: warning message is misaligned
[Describe test coverage new/current, TreeHerder]: nope, styling change only
[Risks and why]: 0-none, fix for a misalignment that's specifically targeted at that message that is misaligned, analogous to other changes from bug 1273974.
[String/UUID change made/needed]: nope
Attachment #8795417 - Flags: approval-mozilla-beta?
Attachment #8795417 - Flags: approval-mozilla-aurora?
Comment on attachment 8795417 [details] [diff] [review]
Bug1305698.patch

CSS only, low risk, Aurora51+, Beta50+
Attachment #8795417 - Flags: approval-mozilla-beta?
Attachment #8795417 - Flags: approval-mozilla-beta+
Attachment #8795417 - Flags: approval-mozilla-aurora?
Attachment #8795417 - Flags: approval-mozilla-aurora+
I was able to reproduce the initial issue on Firefox 52.0a1 (2016-09-27) under Windows 10 64-bit.

Verified fixed on  Firefox 52.0a1 (2016-09-29), Firefox 51.0a2 (2016-09-29), Firefox 50.0b3 unbranded build (20160929120120) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.10.5. "Some add-ons have been disabled" paragraph is correctly displayed.
Thanks for the fix! We added this contribution here: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#September_2016
You need to log in before you can comment on or make changes to this bug.