1305749 - Firefox 49.x: After upgrade from 48 saved passwords are not displayed in the password manager

Status: RESOLVED INACTIVE

(Toolkit :: Password Manager, defect)

Description

[u580523]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

I did upgrade from Firefox 48.x to 49.0.


Actual results:

After the upgrade the password managers does not display any password that were displayed in Firefox 48. If I revert back to Firefox 48 I can see all my passwords again.


Expected results:

The password shall be displayed properly in Firefox 49.

Comment 1

[Loic]

Does it work if you start FF49 in safe mode?
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 2

[u580523]

(In reply to Loic from comment #1)
> Does it work if you start FF49 in safe mode?
> https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-
> mode

Nope, safe mode does not change anything.

In meantime, I did another test - moved my profile to Linux machine. In this case, all my saved passwords are shown in the password manager in FF 49. So, issue seems to be Windows OS related.

Is there any way do enable traces in FF?

Comment 3

[Loic]

Could you make this simple test on Windows:

1) Create a fresh new profile:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles
2) Open your current profile folder (there is a button in the about:support page)
3) Copy the files related to your passwords (key3.db & logins.json) to the new profile folder
4) Start Firefox with the new profile

Are the pwds visible in the pwd manager?

Comment 4

[u580523]

(In reply to Loic from comment #3)
> Could you make this simple test on Windows:
> 
> 1) Create a fresh new profile:
> https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-
> firefox-profiles
> 2) Open your current profile folder (there is a button in the about:support
> page)
> 3) Copy the files related to your passwords (key3.db & logins.json) to the
> new profile folder
> 4) Start Firefox with the new profile
> 
> Are the pwds visible in the pwd manager?

I upgraded FF and followed your steps - passwords were not visible in the pwd manager.
After downgrading FF I saw passwords in both profiles.

Comment 5

[Loic]

This is weird. Are you using a 3rd-party password manager on your machine like Lastpass or provided by your antivirus?

Comment 6

[u580523]

(In reply to Loic from comment #5)
> This is weird. Are you using a 3rd-party password manager on your machine
> like Lastpass or provided by your antivirus?

Nope, I don't use any password managers.

As I already mentioned, I can collect traces for you, if this is possible.
Maybe you have a tool, which may validate my login related files (key3.db, logins.json)?

Comment 7

[Loic]

I can test if it's reproducible on my machine.

Downgrade to FF48.
Open the new profile with key3.db/logins.json imported from your main profile.
Erase pwds to keep only 1 or 2 pwds which are not private (like random websites with guest accounts or something like that).
Verifiy this short pwd list is not visible with FF49 (the bug).
Attach both files to the bug report.

Comment 8

[u580523]

Attachment: Zip file with trimmed logins file

Attaching logins file and key with a single entry.

Comment 9

[Loic]

Attachment: Capture d’écran 2016-09-29 à 20.07.28.png

WFM with FF49, I see the "cisco" login.

Comment 10

[u580523]

(In reply to Loic from comment #9)
> Created attachment 8796256 [details]
> Capture d’écran 2016-09-29 à 20.07.28.png
> 
> WFM with FF49, I see the "cisco" login.

That's correct. 

What else I can do ? Do you want to investigate this issue deeply ?

You can give me hint how to export - import my logins in clear form and then we can close ticket.

Comment 11

[Loic]

Yes, you can use the add-on Password Exporter to export the pwd list and import it (in anew profile eg).
See https://addons.mozilla.org/en-US/firefox/addon/password-exporter/

Before using the add-on, make a back-up copy of key3.db& logins.json!

You can export the list with your profile on 48, then upgrade to 49 (so the add-on will be still here) and import the list.

Comment 12

[u580523]

(In reply to Loic from comment #11)
> Yes, you can use the add-on Password Exporter to export the pwd list and
> import it (in anew profile eg).
> See https://addons.mozilla.org/en-US/firefox/addon/password-exporter/
> 
> Before using the add-on, make a back-up copy of key3.db& logins.json!
> 
> You can export the list with your profile on 48, then upgrade to 49 (so the
> add-on will be still here) and import the list.

Thanks for the hint.

I found something weird. I did export with the password exporter. Then I tried to import passwords in FF 49, but the process were just hanging, I was not able to stop it without killing FF process. Then I downgraded FF to 45ESR (I am working now on this version just to avoid automatic upgrading) and I was able to import passwords properly.

Comment 13

[u580523]

(In reply to [e-mail] from comment #12)
> (In reply to Loic from comment #11)
> > Yes, you can use the add-on Password Exporter to export the pwd list and
> > import it (in anew profile eg).
> > See https://addons.mozilla.org/en-US/firefox/addon/password-exporter/
> > 
> > Before using the add-on, make a back-up copy of key3.db& logins.json!
> > 
> > You can export the list with your profile on 48, then upgrade to 49 (so the
> > add-on will be still here) and import the list.
> 
> Thanks for the hint.
> 
> I found something weird. I did export with the password exporter. Then I
> tried to import passwords in FF 49, but the process were just hanging, I was
> not able to stop it without killing FF process. Then I downgraded FF to
> 45ESR (I am working now on this version just to avoid automatic upgrading)
> and I was able to import passwords properly.

I forgot to mention, that I did not change profile. 
I am going to create another profile and import all my data.

Comment 14

[u580523]

Okay, I did as follows upgraded to FF 49.0.1, created a new profile, tried to import saved passwords - import stuck, I had to kill FF process.

FYI, disk is encrypted with the bitlocker. I am not sure if this may have any impact on observed problem.

Any idea what else we can check?

Comment 15

[Loic]

Yes, the next step is to find a regression in FF49, as FF48 works.
To narrow down the regression range, use the tool mozregression: http://mozilla.github.io/mozregression/

Before running the tool, create a new testing profile and import both files key3.db & logins.json.
When running Mozreg, use the command mozregression --good=48 --profile=path_to_profile

So each time a nightly build is downloaded, you can check directly if the pwd list is displayed or not.

After ther run, copy here the final pushlog from the repository mozilla-inbound.

Comment 16

[u580523]

I've used mozregression-gui toool and not found any working build between 48-49. That's weird.
I'll use the command line tool tomorrow, because I noticed that gui version uses always default profile, whichever profile I select in the wizard.

Comment 17

[Loic]

NB: for the command line version, you need to install python 2.7 (it's easy), because Mozreg is a python 2.7 package.

Comment 18

[u580523]

Attachment: Debug build test log file

Attaching a log file (firefox-1305749-20160930-01.txt) from test using debug build of FF. The tested FF build has been selected by mozregression tool. This was the only tested build, because the mozreg tool has given up as the result was not expected (I did not see my saved passwords).

In the attached log, you can find an error that may be interesting for you:
1:14.90 INFO: JavaScript error: resource://gre/components/crypto-SDR.js, line 66: : Component returned failure code: 0x805a1f9b [nsIPK11Token.initPassword]

Comment 19

[Loic]

Does it work if you start with --good=47 (or even older like 46 or 45)?

Comment 20

[u580523]

(In reply to Loic from comment #19)
> Does it work if you start with --good=47 (or even older like 46 or 45)?

I tried with 45, same behavior and error reported.

Comment 21

[u580523]

Now, I did test with 45.0a1 and 52.0a1 builds, but 64 bits versions and both display passwords properly.

I don't use 32bits builds because of lack of support for a Symantec plugin.

Comment 22

[u580523]

So, I see that FF 49 64-bits works for me (in term of password manager), but not 32-bits build.
Do you have idea why the 32-bits does not work?

Comment 23

[Loic]

What's this Symantec plugin? Do you have Symantec products loaded inFirefox related to pwd managing?

Comment 24

[u580523]

(In reply to Loic from comment #23)
> What's this Symantec plugin? Do you have Symantec products loaded inFirefox
> related to pwd managing?

The only Symantec plugin in FF is Symantec PKI Client 4.12.0.0.
As I already mentioned, I don't use any password managers on my computer.

I also mentioned in comment #2 that the safe mode does not help me on the issue, in this mode I believe all plugins remain disabled.

Comment 25

[Loic]

I found that: http://forums.mozillazine.org/viewtopic.php?p=14421383#p14421383

In the fresh profile with both files key3.db and logins.json, can you define a master password to check if you can get the password list when logging to a website needing to enter a pwd stored in Firefox.

Comment 26

[u580523]

(In reply to Loic from comment #25)
> I found that:
> http://forums.mozillazine.org/viewtopic.php?p=14421383#p14421383
> 
> In the fresh profile with both files key3.db and logins.json, can you define
> a master password to check if you can get the password list when logging to
> a website needing to enter a pwd stored in Firefox.

I did test as follows:
- created new profile with 45ESR
- copied key3 + logins files
- started 45ESR to check if logins are shown properly - OK
- upgrade to 49
- attempted to set master password - KO
- downgraded to 45ESR
- set master password - OK
- restart 45ESR - after entering master password - all logins in place
- upgraded to 49
- option "use a master password" was unchecked
- password manager did not ask for master password - no logins shown on the list

Comment 27

[u580523]

I have same problem after upgrading to FF 50.

Comment 28

[u580523]

Hi,

The problem observed by me, has been solved in one of recent releases.

Thanks,