1305764 - Missing rating-unrated.png referenced from chrome://mozapps/skin/extensions/extensions.css

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Florian Quèze [:florian]]

From bug 1221383:
missing chrome://mozapps/skin/extensions/rating-unrated.png referenced from chrome://mozapps/skin/extensions/extensions.css

Bug 601022 removed the rating-unrated.png file on all platforms, but kept the reference in the Linux extensions.css file:

file removal for linux: https://hg.mozilla.org/mozilla-central/rev/367398a8cbfe#l22.27

removal of the rule on Mac: https://hg.mozilla.org/mozilla-central/rev/367398a8cbfe#l30.928

removal of the rule on Windows: https://hg.mozilla.org/mozilla-central/rev/367398a8cbfe#l51.954

All we need to do here is remove these lines:
.meta-rating[showrating="user"] > .star {
  list-style-image: url("chrome://mozapps/skin/extensions/rating-unrated.png");
  padding: 2px 3px;
}

at http://searchfox.org/mozilla-central/rev/767e1e9b118269f957ca1817138472146278a29e/toolkit/themes/linux/mozapps/extensions/extensions.css#38

Comment 1

[Abhinav Srivastava]

Hi,

I am Abhinav Srivastava and I've been working on HTML/CSS/JavaScript from last one and half years. So, I would like to work on this bug, please guide me.


Thanks & Regards,
Abhinav

Comment 2

[Florian Quèze [:florian]]

Hi Abhinav,

Have you already downloaded the Firefox source code? Once you have, you can follow the instructions at the end of the bug description here (click the last link to see where the lines that need to be removed are). Let me know if you have questions :-).

Comment 3

[rgargrajatgarg]

Hi,

I am Rajat Garg I've downloaded the Firefox source code and have build it on my machine.I have made the changes required for this bug locally.What next I have to do merge the change.

Thanks & Regards,
Rajat

Comment 4

[Florian Quèze [:florian]]

You need to attach a patch to this bug and request review on it (I would be a suitable reviewer).

There is documentation at https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Submitting_the_patch

Comment 5

[rgargrajatgarg]

Attachment: Removed the specified lines from specified file

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8797641 [details] [diff] [review]
Removed the specified lines from specified file

Review of attachment 8797641 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! The code change looks good, but the patch isn't in a format suitable for being checked in. It looks like you created this diff using the diff command rather than using hg export or hgbzexport.

See https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Your patch file should contain a commit message and the name/email of the author.

Comment 7

[rgargrajatgarg]

Attachment: Bug 1305764 Removed the rating-unrated.png refrence from linux extensions.css file.

Review commit: https://reviewboard.mozilla.org/r/83322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83322/

Comment 8

[rgargrajatgarg]

Attachment: Bug 1305764-Removed the rating-unrated.png reference in the Linux extensions.css file. Quèze [:florian] [:flo]

Review commit: https://reviewboard.mozilla.org/r/83324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83324/

Comment 9

[rgargrajatgarg]

Hi,
   I mistakenly pushed the wrong change in my first commit and then corrected that in second and removed the  reference of the missing file too but now how do i squash them or delete the wrong changes.What should i do next?

Thanks
Rajat garg

Comment 10

[Florian Quèze [:florian]]

The hg histedit command supports folding changesets. See https://www.mercurial-scm.org/wiki/HisteditExtension

Note: in commit messages we usually only take the IRC nick of the reviewer, so for me it would be r=florian

Comment 11

[rgargrajatgarg]

Comment on attachment 8797677 [details]
Bug 1305764 Removed the rating-unrated.png refrence from linux extensions.css file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83322/diff/1-2/

Comment 12

[Florian Quèze [:florian]]

Comment on attachment 8797677 [details]
Bug 1305764 Removed the rating-unrated.png refrence from linux extensions.css file.

https://reviewboard.mozilla.org/r/83322/#review82186

Looks good, thanks!

Note: when folding the 2 changesets, mercurial concatenated the commit messages.

Comment 13

[Florian Quèze [:florian]]

If you would be interested in working on another bug similar to this one, there's bug 1305748 that you can have a look at.

Comment 14

[rgargrajatgarg]

(In reply to Florian Quèze [:florian] [:flo] from comment #13)
> If you would be interested in working on another bug similar to this one,
> there's bug 1305748 that you can have a look at.

Thanks florian for helping me out in solving my first bug.And thanks to IRC channel too.I would love to work on another bug.
Rajat garg

Comment 15

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/f732bc68879c82010aae7d030483dd5985c69f75
Bug 1305764 - Removed the rating-unrated.png refrence from linux extensions.css file. r=florian

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f732bc68879c