1305890 - [webvr] Support Oculus Touch button and analogue inputs in the Gamepad API

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305890 - Part 1: Oculus Touch button inputs support;

Review commit: https://reviewboard.mozilla.org/r/111100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111100/

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305890 - Part 2: Oculus Touch axis move support;

Review commit: https://reviewboard.mozilla.org/r/111102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111102/

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305890 - Part 3: Change OpenVR and Oculus Touch gamepad id;

Review commit: https://reviewboard.mozilla.org/r/111474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111474/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8835394 [details]
Bug 1305890 - Part 1: Oculus Touch button inputs support;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111100/diff/1-2/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8835395 [details]
Bug 1305890 - Part 2: Oculus Touch axis move support;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111102/diff/1-2/

Comment 6

[Daosheng Mu[:daoshengmu]]

In this update, I change the gamepad id of Oculus and OpenVR to Chromium's and following the button and axes mapping as they did.

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8835394 [details]
Bug 1305890 - Part 1: Oculus Touch button inputs support;

https://reviewboard.mozilla.org/r/111100/#review113010

Looks good

Comment 8

[:kip (Kearwood Gilbert)]

Comment on attachment 8835395 [details]
Bug 1305890 - Part 2: Oculus Touch axis move support;

https://reviewboard.mozilla.org/r/111102/#review113030

Comment 9

[:kip (Kearwood Gilbert)]

Comment on attachment 8835917 [details]
Bug 1305890 - Part 3: Change OpenVR and Oculus Touch gamepad id;

https://reviewboard.mozilla.org/r/111474/#review113028

::: gfx/vr/gfxVROculus.cpp:839
(Diff revision 1)
>  
>  VRControllerOculus::VRControllerOculus()
>    : VRControllerHost(VRDeviceType::Oculus)
>  {
>    MOZ_COUNT_CTOR_INHERITED(VRControllerOculus, VRControllerHost);
> -  mControllerInfo.mControllerName.AssignLiteral("Oculus Touch Controller");
> +  mControllerInfo.mControllerName.AssignLiteral("Oculus Touch");

Rather than setting a value of "Oculus Touch" that will later be replaced in VRControllerOculus::SetHand(), perhaps we could refactor VRControllerHost to accept the "hand" parameter in the constructor.  (Assuming that handedness does not change after initialization)

This could be done as a separate clean-up task in another bug; however.

Comment 10

[Daosheng Mu[:daoshengmu]]

(In reply to :kip (Kearwood Gilbert) from comment #9)
> Comment on attachment 8835917 [details]
> Bug 1305890 - Part 3: Change OpenVR and Oculus Touch gamepad id;
> 
> https://reviewboard.mozilla.org/r/111474/#review113028
> 
> ::: gfx/vr/gfxVROculus.cpp:839
> (Diff revision 1)
> >  
> >  VRControllerOculus::VRControllerOculus()
> >    : VRControllerHost(VRDeviceType::Oculus)
> >  {
> >    MOZ_COUNT_CTOR_INHERITED(VRControllerOculus, VRControllerHost);
> > -  mControllerInfo.mControllerName.AssignLiteral("Oculus Touch Controller");
> > +  mControllerInfo.mControllerName.AssignLiteral("Oculus Touch");
> 
> Rather than setting a value of "Oculus Touch" that will later be replaced in
> VRControllerOculus::SetHand(), perhaps we could refactor VRControllerHost to
> accept the "hand" parameter in the constructor.  (Assuming that handedness
> does not change after initialization)
> 
> This could be done as a separate clean-up task in another bug; however.

Good suggestion. I will refactor it at the follow-up bug.

Thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ce888be3200
Part 1: Oculus Touch button inputs support; r=kip
https://hg.mozilla.org/integration/autoland/rev/23b92e78be6b
Part 2: Oculus Touch axis move support; r=kip
https://hg.mozilla.org/integration/autoland/rev/e6a5ccd4772d
Part 3: Change OpenVR and Oculus Touch gamepad id; r=kip

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4ce888be3200
https://hg.mozilla.org/mozilla-central/rev/23b92e78be6b
https://hg.mozilla.org/mozilla-central/rev/e6a5ccd4772d