1305959 - [Static Analysis][Uninitialized scalar field] In constructor ClientNavigateRunnable

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Paul Bignier]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160921132349

Comment 1

[Paul Bignier]

Attachment: Initialize a ClientNavigateRunnable member

* Run() seems to be the initializer but it can exit early so need to initiliaze to square with the coming MOZ_ASSERT(mWorkerPrivate);

Comment 2

[Paul Bignier]

Hi Johnny,
Could you please route this patch to the concerned person? I'm not sure who it is and all the dom/workers/ peers are tagged as "not receiving bugmail".
Thank you,
Paul

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 8795672 [details] [diff] [review]
Initialize a ClientNavigateRunnable  member

Ben Kelly (:bkelly) would probably be the best person to look at this, though he's out this week is looks like, so baku can hopefully help sooner.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8795672 [details] [diff] [review]
Initialize a ClientNavigateRunnable  member

Review of attachment 8795672 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerWindowClient.cpp
@@ +335,5 @@
>                           PromiseWorkerProxy* aPromiseProxy)
>      : mWindowId(aWindowId)
>      , mUrl(aUrl)
>      , mPromiseProxy(aPromiseProxy)
> +    , mWorkerPrivate()

, mWorkerPrivate(nullptr)

Comment 5

[Paul Bignier]

Attachment: Initialize a ClientNavigateRunnable member

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f10953ecc7ab
Initialize a ClientNavigateRunnable member. r=baku

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f10953ecc7ab