1306112 - Fixups from bug 1289050

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: No bug - Fix typo.

Review commit: https://reviewboard.mozilla.org/r/81842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81842/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: No bug - Remove unused ValidateTextureTargetEnum.

Review commit: https://reviewboard.mozilla.org/r/81844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81844/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1306112 - Inline singly-used ValidateDataRanges. -

Review commit: https://reviewboard.mozilla.org/r/81846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81846/

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1306112 - `separate` should use <=, not <. -

Review commit: https://reviewboard.mozilla.org/r/81848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81848/

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1306112 - With calloc, use UniqueBuffer instead of UniquePtr. -

Review commit: https://reviewboard.mozilla.org/r/81850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81850/

Comment 6

[Ethan Lin[:ethlin]]

Comment on attachment 8795891 [details]
Bug 1306112 - `separate` should use <=, not <. -

https://reviewboard.mozilla.org/r/81848/#review80648

Comment 7

[Ethan Lin[:ethlin]]

Comment on attachment 8795892 [details]
Bug 1306112 - With calloc, use UniqueBuffer instead of UniquePtr. -

https://reviewboard.mozilla.org/r/81850/#review80652

Comment 8

[Ethan Lin[:ethlin]]

Comment on attachment 8795890 [details]
Bug 1306112 - Inline singly-used ValidateDataRanges. -

https://reviewboard.mozilla.org/r/81846/#review80654

Comment 9

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8795892 [details]
Bug 1306112 - With calloc, use UniqueBuffer instead of UniquePtr. -

Fixed by a different bug.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd3e0479280
Inline singly-used ValidateDataRanges. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/44c66bf22571
`separate` should use <=, not <. - r=ethlin

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cd3e0479280
https://hg.mozilla.org/mozilla-central/rev/44c66bf22571

Comment 12

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8795888 [details]
No bug - Fix typo.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

This and other patches.

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8795888 [details]
No bug - Fix typo.

Fix a WebGL 2 issue. Beta51+. Should be in 51 beta 3.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47231fa87f23
https://hg.mozilla.org/releases/mozilla-beta/rev/01b98cd6930c