Closed Bug 1306112 Opened 3 years ago Closed 3 years ago

Fixups from bug 1289050

Categories

(Core :: Canvas: WebGL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(4 files, 1 obsolete file)

No description provided.
Priority: -- → P1
Whiteboard: gfx-noted
Summary: Mismatched calloc with UniquePtr → Fixups from bug 1289050
Comment on attachment 8795891 [details]
Bug 1306112 - `separate` should use <=, not <. -

https://reviewboard.mozilla.org/r/81848/#review80648
Attachment #8795891 - Flags: review?(ethlin) → review+
Comment on attachment 8795892 [details]
Bug 1306112 - With calloc, use UniqueBuffer instead of UniquePtr. -

https://reviewboard.mozilla.org/r/81850/#review80652
Attachment #8795892 - Flags: review?(ethlin) → review+
Comment on attachment 8795890 [details]
Bug 1306112 - Inline singly-used ValidateDataRanges. -

https://reviewboard.mozilla.org/r/81846/#review80654
Attachment #8795890 - Flags: review?(ethlin) → review+
Comment on attachment 8795892 [details]
Bug 1306112 - With calloc, use UniqueBuffer instead of UniquePtr. -

Fixed by a different bug.
Attachment #8795892 - Attachment is obsolete: true
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd3e0479280
Inline singly-used ValidateDataRanges. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/44c66bf22571
`separate` should use <=, not <. - r=ethlin
https://hg.mozilla.org/mozilla-central/rev/1cd3e0479280
https://hg.mozilla.org/mozilla-central/rev/44c66bf22571
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795888 [details]
No bug - Fix typo.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

This and other patches.
Attachment #8795888 - Flags: approval-mozilla-beta?
Comment on attachment 8795888 [details]
No bug - Fix typo.

Fix a WebGL 2 issue. Beta51+. Should be in 51 beta 3.
Attachment #8795888 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.