Closed Bug 1306140 Opened 4 years ago Closed 4 years ago

Add tests to ensure there is always one default homepanel after HomePanel migrations

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: ahunt, Assigned: ahunt)

References

Details

(Whiteboard: [MobileAS])

Attachments

(3 files)

HomePanelConfig migrations that resulted in no default panel being set have bitten us twice:
 - Bug 1304777
 - Bug 1264136

We should add some tests that ideally walk through every permutation, to ensure that we never end up without a default homepanel being set.
Assignee: nobody → ahunt
Depends on: 1304777
Priority: -- → P1
Whiteboard: [MobileAS]
Comment on attachment 8796268 [details]
Bug 1306140 - Pre: move HomeConfig migration loop into separate method to help with testing

https://reviewboard.mozilla.org/r/82174/#review80754
Attachment #8796268 - Flags: review?(s.kaspari) → review+
Comment on attachment 8796269 [details]
Bug 1306140 - Pre: make HomeConfig VERSION package-private to allow access for testing

https://reviewboard.mozilla.org/r/82176/#review80756

::: mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java:39
(Diff revision 1)
>  
>  public class HomeConfigPrefsBackend implements HomeConfigBackend {
>      private static final String LOGTAG = "GeckoHomeConfigBackend";
>  
>      // Increment this to trigger a migration.
> -    private static final int VERSION = 8;
> +    /* package-private */ static final int VERSION = 8;

If this is just for testing then you could add @VisibleForTesting instead of the comment here.
Attachment #8796269 - Flags: review?(s.kaspari) → review+
Comment on attachment 8796270 [details]
Bug 1306140 - Add tests for HomeConfig migration

https://reviewboard.mozilla.org/r/82178/#review80766
Attachment #8796270 - Flags: review?(s.kaspari) → review+
Status: NEW → ASSIGNED
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39b96ac89699
Pre: move HomeConfig migration loop into separate method to help with testing r=sebastian
https://hg.mozilla.org/integration/autoland/rev/aeccc63b252a
Pre: make HomeConfig VERSION package-private to allow access for testing r=sebastian
https://hg.mozilla.org/integration/autoland/rev/cdf154426881
Add tests for HomeConfig migration r=sebastian
Iteration: --- → 1.5
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.