1306222 - Use NeedsSubjectPrincipal in DataTransfer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: explicit_principal5.patch

Comment 1

[Andrea Marchesini [:baku]]

Attachment: explicit_principal5.patch

Comment 2

[(no longer active)]

Comment on attachment 8796043 [details] [diff] [review]
explicit_principal5.patch

Review of attachment 8796043 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/ClipboardEvent.cpp
@@ +75,5 @@
>        // support other types of events, make sure that read/write privileges are
>        // checked properly within DataTransfer.
>        clipboardData = new DataTransfer(ToSupports(e), eCopy, false, -1);
> +      clipboardData->SetData(aParam.mDataType, aParam.mData,
> +                             Some(nsContentUtils::SubjectPrincipal()), aRv);

Instead of doing this, you should make the constructor [NeedsSubjectPrincipal] and just pass the result down.  I suppose we need to add a [ConstructorNeedsSubjectPrincipal] attribute?  Or, we can make [NeedsSubjectPrincipal] appearing on an interface with [Constructor] mean the constructor needs a subject principal?  The latter feels a bit gross.

::: dom/events/DataTransfer.cpp
@@ +437,5 @@
>  NS_IMETHODIMP
>  DataTransfer::GetData(const nsAString& aFormat, nsAString& aData)
>  {
>    ErrorResult rv;
> +  GetData(aFormat, aData, Some(nsContentUtils::SubjectPrincipal()), rv);

Can we remove this?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 1 - GlobalObject::GetSubjectPrincipal

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 2 - DataTransfer & friends

Comment 5

[Andrea Marchesini [:baku]]

Still working about removing nsIDOMDataTransfer::GetData

Comment 6

[Andrea Marchesini [:baku]]

And that can be done in a follow up.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/069d41a294b8
Introducing GlobalObject::GetSubjectPrincipal, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ea28929a0c
Use NeedsSubjectPrincipal in DataTransfer, r=ehsan

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/069d41a294b8
https://hg.mozilla.org/mozilla-central/rev/d1ea28929a0c